From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2411 invoked by alias); 6 Sep 2007 23:18:44 -0000 Received: (qmail 2394 invoked by uid 22791); 6 Sep 2007 23:18:43 -0000 X-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e6.ny.us.ibm.com (HELO e6.ny.us.ibm.com) (32.97.182.146) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 06 Sep 2007 23:18:37 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l86NK0Or007943 for ; Thu, 6 Sep 2007 19:20:00 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l86NIZv3430588 for ; Thu, 6 Sep 2007 19:18:35 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l86NIZjc029375 for ; Thu, 6 Sep 2007 19:18:35 -0400 Received: from [9.47.18.96] (dyn9047018096.beaverton.ibm.com [9.47.18.96]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l86NIYu7029360; Thu, 6 Sep 2007 19:18:34 -0400 Subject: Re: Updated uprobes patches From: Jim Keniston To: David Wilder Cc: SystemTap In-Reply-To: <46E04D51.4010305@us.ibm.com> References: <20070822141241.GB25386@linux.vnet.ibm.com> <46E04D51.4010305@us.ibm.com> Content-Type: text/plain Date: Fri, 07 Sep 2007 09:12:00 -0000 Message-Id: <1189120728.3608.15.camel@dyn9047018096.beaverton.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00528.txt.bz2 On Thu, 2007-09-06 at 11:56 -0700, David Wilder wrote: > Srikar Dronamraju wrote: > > Hi All, > > > > I just updated uprobes patches to rearrange some of the files. > > Architecture dependent files are moved to their corresponding arch > > directories. > > > > Uprobes can now be built into the kernel or built as a module on > > i386, powerpc, and s390. > > Please do review and let me know your comments. > > > > The updated patches are available at /cvs/patches/uprobes directory. > > The current set of patches are > > > > uprobes-all-i386.patch > > uprobes-powerpc.patch > > uprobes-s390.patch > > > > -- > > Thanks and Regards > > Srikar Dronamraju > > > I verified uprobes-s390.patch and ran the tests. No failures were seen. > I tested both as a built-in and as a module. Good. Thanks. > > One minor issue was that the patch did not apply cleanly to some of the > arch specific Kconfig and Makefile on the > 2.6.21-rc6-mm1 kernel. You must have been using a different kernel than > I. What kernel tree were the patches build against? The Makefiles and Kconfig files are the only places the uprobes patches touch existing kernel code, and patch-rejects in those files are easy to hand-patch, so we haven't been releasing kernel-version-specific uprobes patches. The other drawback to this approach is that if you want to build uprobes as a module, you may have to add, by hand, EXPORT_SYMBOL_GPL statements for access_process_vm, __put_task_struct, and/or tasklist_lock, depending on the kernel. Jim