From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
systemtap-ml <systemtap@sources.redhat.com>,
Hideo AOKI <haoki@redhat.com>
Subject: Re: [RFC][Patch 2/2] markers: example of irq regular kernel markers
Date: Sat, 21 Jun 2008 10:14:00 -0000 [thread overview]
Message-ID: <1213992446.3223.195.camel@lappy.programming.kicks-ass.net> (raw)
In-Reply-To: <20080620174529.GB10943@Krystal>
On Fri, 2008-06-20 at 13:45 -0400, Mathieu Desnoyers wrote:
> All this work look good, thanks Masami! Sorry I did not find time to do
> it lately, I've been busy on other things. A small question though :
> since LTTng is configurable both as an external module or as an
> in-kernel tracer, I wonder if it would really hurt to add the format
> strings to DEFINE_TRACE, e.g. :
>
> DEFINE_TRACE(name, prototype, format_string, args...)
>
> which would give :
>
> DEFINE_TRACE(irq_entry, (int irq_id, int kernel_mode), "%d %d",
> irq_id, kernel_mode);
>
> DEFINE_TRACE(irq_exit, (void), MARK_NOARGS);
>
> and calling this in the kernel code :
>
> trace_irq_entry(irq, (regs)?(!user_mode(regs)):(1));
> ...
> trace_irq_exit();
>
> and for quick-and-dirty debug usage, one would add this to kernel code :
>
> trace_mark(subsystem_event, "(int arg, struct task_struct *task)",
> "%d %p", arg, current);
How would this work for:
DEFINE_TRACE(sched_switch, (struct task_struct *prev, struct task_struct *next), prev, next);
You'd want a string like: "%d %d", prev->pid, next->pid
not: "%p %p", prev, next
perhaps we can do something like:
DEFINE_TRACER(sched_switch, (struct task_struct *prev, struct task_struct *next), prev, next,
"%d %d", prev->pid, next->pid);
that defines a default tracer function for the previously defined trace
point. That way its optional, and allows for generic trace points.
Of course, all this could be ruined by reality - C really sucks wrt
forwarding functions.. :-/
next prev parent reply other threads:[~2008-06-20 20:08 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 19:36 Masami Hiramatsu
2008-06-20 22:16 ` Mathieu Desnoyers
2008-06-20 23:23 ` Masami Hiramatsu
2008-06-21 15:08 ` KOSAKI Motohiro
2008-06-21 18:04 ` Steven Rostedt
2008-06-21 19:41 ` Frank Ch. Eigler
2008-06-22 4:03 ` Steven Rostedt
2008-06-22 4:32 ` Peter Zijlstra
2008-06-22 17:12 ` Frank Ch. Eigler
2008-06-23 2:20 ` Masami Hiramatsu
2008-06-23 7:08 ` KOSAKI Motohiro
2008-06-22 18:03 ` Frank Ch. Eigler
2008-06-22 18:27 ` Masami Hiramatsu
2008-06-21 10:14 ` Peter Zijlstra [this message]
2008-06-23 3:06 ` [RFC] Tracepoint proposal Mathieu Desnoyers
2008-06-23 6:34 ` Alexey Dobriyan
2008-06-23 6:51 ` Mathieu Desnoyers
2008-06-24 7:15 ` Alexey Dobriyan
2008-06-24 11:39 ` Masami Hiramatsu
2008-06-24 13:23 ` Takashi Nishiie
2008-06-24 16:23 ` Frank Ch. Eigler
2008-06-24 19:43 ` Masami Hiramatsu
2008-06-25 1:08 ` KOSAKI Motohiro
2008-06-25 1:36 ` Masami Hiramatsu
2008-06-25 1:49 ` Mathieu Desnoyers
2008-06-26 16:20 ` [RFC PATCH] Tracepoint sched probes Mathieu Desnoyers
2008-06-26 17:01 ` [RFC PATCH] Kernel Tracepoints Mathieu Desnoyers
2008-06-27 13:21 ` Masami Hiramatsu
2008-06-27 15:00 ` Mathieu Desnoyers
2008-06-29 18:46 ` Masami Hiramatsu
2008-06-30 18:21 ` Mathieu Desnoyers
2008-06-27 15:07 ` Mathieu Desnoyers
2008-06-30 20:11 ` Masami Hiramatsu
2008-06-27 15:48 ` Mathieu Desnoyers
2008-06-28 0:05 ` Masami Hiramatsu
2008-06-30 17:14 ` Mathieu Desnoyers
2008-06-30 20:17 ` Masami Hiramatsu
2008-07-03 15:13 ` Mathieu Desnoyers
2008-07-03 18:53 ` Masami Hiramatsu
2008-06-27 16:11 ` [RFC PATCH] Kernel Tracepoints (update) Mathieu Desnoyers
2008-07-03 15:29 ` Masami Hiramatsu
2008-07-03 15:47 ` Mathieu Desnoyers
2008-07-03 18:19 ` Mathieu Desnoyers
2008-07-03 18:48 ` Masami Hiramatsu
2008-06-24 11:06 ` [RFC] Tracepoint proposal Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213992446.3223.195.camel@lappy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fche@redhat.com \
--cc=haoki@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).