From: Mark Wielaard <mjw@redhat.com>
To: systemtap@sourceware.org
Cc: zhaolei@sourceware.org
Subject: Re: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-0.7-276-g707e14f
Date: Tue, 23 Sep 2008 11:07:00 -0000 [thread overview]
Message-ID: <1222167982.3178.82.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <20080922041903.5055.qmail@sourceware.org>
[Sorry about the resent, apparently the systemtap-cvs list doesn't
accept email. Would it be possible to set the reply-to on those emails
to the main systemtap list in case someone does want to reply to them?]
Hi Zhaolei,
On Mon, 2008-09-22 at 04:19 +0000, zhaolei@sourceware.org wrote:
> commit 707e14f086aa2b527f1e75aafdf6331356675e0a
> Author: Zhaolei <zhaolei@cn.fujitsu.com>
> Date: Mon Sep 22 12:15:11 2008 +0800
>
> socket.stp (socket.aio_read/write): Fix the semantic error caused by the difference of kernel versions.
You are using the following logic to detect the right kernel version:
> + *
> + * 2.6.9~2.6.15:
> + * static ssize_t sock_aio_read(struct kiocb *iocb, char __user *ubuf, size
> + * 2.6.16~2.6.18:
> + * static ssize_t sock_aio_read(struct kiocb *iocb, char __user *ubuf, size
> + * 2.6.19~2.6.26:
> + * static ssize_t sock_aio_read(struct kiocb *iocb, const struct iovec *iov
> */
> probe socket.aio_read = kernel.function ("sock_aio_read")
> {
> name = "socket.aio_read"
> _sock = _get_sock_addr ($iocb->ki_filp)
> -%( kernel_v < "2.6.19" %?
> - size = $count
> +%( kernel_v <= "2.6.15" %?
> + size = $size
> %:
> - size = _get_sock_size ($iov, $nr_segs)
> + %( kernel_v <= "2.6.18" %?
> + size = $count
> + %:
> + size = _get_sock_size ($iov, $nr_segs)
> + %)
> %)
Are you sure you want checks like kernel_v <= "2.6.18"? That would
include 2.6.18, but not 2.6.18.1. It seems better (but I don't have the
kernels here to test) to use kernel_v < "2.6.19" there and in other
places.
Cheers,
Mark
next parent reply other threads:[~2008-09-23 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080922041903.5055.qmail@sourceware.org>
2008-09-23 11:07 ` Mark Wielaard [this message]
[not found] ` <1222167517.3178.80.camel@dijkstra.wildebeest.org>
2008-09-23 11:47 ` [SCM] systemtap: system-wide probe/trace tool branch, master,updated. release-0.7-276-g707e14f Zhaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222167982.3178.82.camel@dijkstra.wildebeest.org \
--to=mjw@redhat.com \
--cc=systemtap@sourceware.org \
--cc=zhaolei@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).