public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mjw@redhat.com>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: wenji.huang@oracle.com, SystemTAP <systemtap@sources.redhat.com>,
	        "ZANNONI,ELENA" <ELENA.ZANNONI@oracle.com>
Subject: Re: Labrat reports for 2.6.27-RC snapshot tests
Date: Tue, 28 Oct 2008 12:14:00 -0000	[thread overview]
Message-ID: <1225195998.3415.17.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <20081027170140.GO20331@oracle.com>

Hi Kris,

On Mon, 2008-10-27 at 13:01 -0400, Kris Van Hees wrote:
> On Fri, Oct 24, 2008 at 01:34:26PM +0200, Mark Wielaard wrote:
> << snip>>
> > There is some noise in the output because the script seems to not
> > understand some of the error messages when things fail. e.g.
> > 
> >    FAIL  -> N/A   test - systemtap.samples/gtod.exp(gtod (0))
> >    [...]
> >    N/A   -> PASS  test - systemtap.samples/gtod.exp(gtod (300))
> > 
> > It would be useful to keep either the kernel version or the systemtap
> > snapshot version constant between runs. It looks like currently both are
> > updated at the same time. Although it isn't completely clear, the
> > version is always reported as 0.7.1, it would be good to mention the
> > last git commit (as in stap -V).
> 
> This is actually not something that can easily be solved without hardcoding
> test-specific logic to strip out dynamic content in these messages.  Since
> labrat is not a project-specific reporting system, implementing such hardcoded
> rules would be less desirable.  Also note that wiring this logic in a way
> that is not test specific is somewhat dangerous because you may end stripping
> out important information from the messages unless people are extremely
> careful in how they write the pass/fail messages.
> 
> If there is a very strict convention (one that gets enforced) on how dynamic
> data is included in these messages, I can definitely look at implementing the
> logic to strip it out based on the established conventions.

"extra" output is always between brackets. You can filter on that.
You can get the git commit number with:
$ git rev-parse HEAD | sed -n 's/^\(.\{8\}\).*/\1/p'
You can get the git branch with:
$ git symbolic-ref HEAD | sed -n 's|^refs/heads/||p'
See also the git git_version.sh. That should all be pretty generic.

Cheers,

Mark

      reply	other threads:[~2008-10-28 12:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24  7:06 Wenji Huang
2008-10-24 11:35 ` Mark Wielaard
2008-10-27 17:02   ` Kris Van Hees
2008-10-28 12:14     ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225195998.3415.17.camel@dijkstra.wildebeest.org \
    --to=mjw@redhat.com \
    --cc=ELENA.ZANNONI@oracle.com \
    --cc=kris.van.hees@oracle.com \
    --cc=systemtap@sources.redhat.com \
    --cc=wenji.huang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).