From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18793 invoked by alias); 19 May 2009 16:46:13 -0000 Received: (qmail 18782 invoked by uid 22791); 19 May 2009 16:46:12 -0000 X-SWARE-Spam-Status: No, hits=-0.2 required=5.0 tests=AWL,BAYES_50,J_CHICKENPOX_73,J_CHICKENPOX_83,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e2.ny.us.ibm.com (HELO e2.ny.us.ibm.com) (32.97.182.142) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 May 2009 16:46:04 +0000 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4JGftjB002349 for ; Tue, 19 May 2009 12:41:55 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4JGjoN9766198 for ; Tue, 19 May 2009 12:45:51 -0400 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4JGjhZT012521 for ; Tue, 19 May 2009 10:45:44 -0600 Received: from [9.47.18.94] (dyn9047018094.beaverton.ibm.com [9.47.18.94]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n4JGjgpn012453; Tue, 19 May 2009 10:45:43 -0600 Subject: Re: [PATCH] Complete the names-to-numbers conversion in nd_syscalls.stp. From: Jim Keniston To: =?UTF-8?Q?Przemys=C5=82aw_Pawe=C5=82czyk?= Cc: Josh Stone , systemtap@sourceware.org, JoeLynn_gmail Keniston In-Reply-To: <40e92d5b0905181732h5acadf9amd8387286d6c061aa@mail.gmail.com> References: <1242587305.670381.9610@debian> <4A11F57D.1070006@redhat.com> <40e92d5b0905181732h5acadf9amd8387286d6c061aa@mail.gmail.com> Content-Type: text/plain; charset=UTF-8 Date: Tue, 19 May 2009 16:46:00 -0000 Message-Id: <1242751522.3481.32.camel@dyn9047018094.beaverton.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00630.txt.bz2 On Tue, 2009-05-19 at 02:32 +0200, Przemysław Pawełczyk wrote: > On Tue, May 19, 2009 at 01:55, Josh Stone wrote: > > On 05/17/2009 11:09 AM, Przemyslaw Pawelczyk wrote: > >> Replace in-scope variables references with *_arg functions. Use 'kprobe' > >> family of probes instead of 'kernel' family for dwarfless probing. Also > >> fix a few typos and unify formatting. > > > > Thanks a lot -- this is good work! I went ahead and committed this to > > the repo, but I would ask for a couple more things before we declare > > this "complete". First, as Ananth pointed out, we will eventually need > > to deal with the SYSCALL_WRAPPERS for some archs. Second is that we now > > need to start nd_syscalls2.stp to get the full syscall set. Are you up > > to tackling that as well? > > Yes, this patch isn't complete, but information that I'll prepare > second version was mistakenly sent only to Ananth instead of mailing > list. > Information about future second patch: > - include fix for architectures using SYSCALL_WRAPPERS, > - add missing probe points (already available in syscalls.stp: > faccessat, fchmodat, fchownat, linkat, mknodat), > - remove return aliases for exit and exit_group (PR6588). > > I'm theoretically up to tackle nd_syscalls2.stp, but without any > deadline and as a low priority task. > Conversion from syscalls2?.stp to nd_syscalls2?.stp should be a fully > automatic process, but there is no appropriate script right now. > (Automated generation of syscalls.stp also would be a nice thing.) > Focusing on such a script is IMHO better, but on the other hand it is > one time job. Syscall changes in kernel are rare and further syscalls > modifications will be easily applied by hand. > > > Long term, we'll probably want to rename the dwarf syscall tapset to > > something like dw_syscall, and then provide aliases like: > > probe syscall.foo = dw_syscall.foo !, nd_syscall.foo {} > > Sounds good for me. > > > Josh > > Regards. > JoeLynn Keniston implemented both nd_syscalls.stp and nd_syscalls2.stp last summer. Except for differences in spacing and line breaks, her nd_syscalls.stp looks very close to yours. I'm not sure I ever completed my code review of nd_syscalls2.stp. Unfortunately, support for dwarfless probing was backed out of the translator just about the time she was finishing this work, so testing became a problem and we shelved the project. Since she's not an IBMer, I was not (and am not) able to post or check in her code on her behalf. JoeLynn, please talk to me about posting your versions of nd_syscalls.stp (for comparison) and nd_syscalls2.stp. BTW, we were testing it by probing syscall.*[.return] and nd_syscall.*[.return] in the same script and verifying that each pair of lines in the output matched. Sorry for not closing the loop on this last summer. I know it's been a lot of work. Jim Keniston