From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9199 invoked by alias); 11 Sep 2009 02:33:12 -0000 Received: (qmail 9190 invoked by uid 22791); 11 Sep 2009 02:33:11 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from fifo99.com (HELO fifo99.com) (67.223.236.141) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 02:33:08 +0000 Received: from smtp.fifo99.com (fifo99.com [67.223.236.141]) by fifo99.com (Postfix) with ESMTPSA id A0B842269516 ; Fri, 11 Sep 2009 02:33:05 +0000 (UTC) Subject: Re: [PATCH tracing/kprobes 3/7] tracing/kprobes: Cleanup kprobe tracer code. From: Daniel Walker To: Masami Hiramatsu Cc: Frederic Weisbecker , Steven Rostedt , Ingo Molnar , lkml , systemtap , DLE , Jim Keniston , Ananth N Mavinakayanahalli , Andi Kleen , Christoph Hellwig , "Frank Ch. Eigler" , "H. Peter Anvin" , Jason Baron , "K.Prasad" , Lai Jiangshan , Li Zefan , Peter Zijlstra , Srikar Dronamraju , Tom Zanussi In-Reply-To: <20090910235322.22412.52525.stgit@dhcp-100-2-132.bos.redhat.com> References: <20090910235258.22412.29317.stgit@dhcp-100-2-132.bos.redhat.com> <20090910235322.22412.52525.stgit@dhcp-100-2-132.bos.redhat.com> Content-Type: text/plain Date: Fri, 11 Sep 2009 02:33:00 -0000 Message-Id: <1252636411.30578.224.camel@desktop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00668.txt.bz2 On Thu, 2009-09-10 at 19:53 -0400, Masami Hiramatsu wrote: > Simplify trace_probe to remove an union, and remove some redundant wrappers. > And also, cleanup create_trace_probe() function. > One single checkpatch issue in this one (whitespace).. The rest of the patch set appears to be clean tho .. Daniel