From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20930 invoked by alias); 16 Sep 2009 15:43:36 -0000 Received: (qmail 20922 invoked by uid 22791); 16 Sep 2009 15:43:36 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hrndva-omtalb.mail.rr.com (HELO hrndva-omtalb.mail.rr.com) (71.74.56.123) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Sep 2009 15:43:31 +0000 Received: from [192.168.23.10] (really [74.67.89.75]) by hrndva-omta01.mail.rr.com with ESMTP id <20090916154330136.OVIY11562@hrndva-omta01.mail.rr.com>; Wed, 16 Sep 2009 15:43:30 +0000 Subject: Re: [PATCH tracing/kprobes 2/6] ftrace: Fix trace_add_event_call() to initialize list take 2 From: Steven Rostedt Reply-To: rostedt@goodmis.org To: Masami Hiramatsu Cc: Frederic Weisbecker , Ingo Molnar , lkml , systemtap , DLE , Jim Keniston , Ananth N Mavinakayanahalli , Andi Kleen , Christoph Hellwig , "Frank Ch. Eigler" , "H. Peter Anvin" , Jason Baron , "K.Prasad" , Lai Jiangshan , Li Zefan , Peter Zijlstra , Srikar Dronamraju , Tom Zanussi In-Reply-To: <4AB1077F.6020107@redhat.com> References: <20090914204847.18779.69409.stgit@dhcp-100-2-132.bos.redhat.com> <20090914204904.18779.59422.stgit@dhcp-100-2-132.bos.redhat.com> <1253058681.20020.147.camel@gandalf.stny.rr.com> <4AB0F366.6080000@redhat.com> <1253111371.20020.198.camel@gandalf.stny.rr.com> <4AB1077F.6020107@redhat.com> Content-Type: text/plain Date: Wed, 16 Sep 2009 15:43:00 -0000 Message-Id: <1253115808.20020.199.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00752.txt.bz2 On Wed, 2009-09-16 at 11:42 -0400, Masami Hiramatsu wrote: > Oh, I see, I misunderstood. Thank you for pointing it out. :) > Here, I updated the patch. Thanks! Acked-by: Steven Rostedt for the whole series. -- Steve > > --- > ftrace: Fix trace_add_event_call() to initialize list > > From: Masami Hiramatsu > > Handle failuer path in trace_add_event_call() for fixing below bug > which occurred when I tried to add invalid event twice. > > Could not create debugfs 'kmalloc' directory > Failed to register kprobe event: kmalloc > Faild to register probe event(-1) > ------------[ cut here ]------------ > WARNING: at /home/mhiramat/ksrc/random-tracing/lib/list_debug.c:26 > __list_add+0x27/0x5c() > Hardware name: > list_add corruption. next->prev should be prev (c07d78cc), but was > 00001000. (next=d854236c). > Modules linked in: sunrpc uinput virtio_net virtio_balloon i2c_piix4 pcspkr > i2c_core virtio_blk virtio_pci virtio_ring virtio [last unloaded: > scsi_wait_scan] > Pid: 1394, comm: tee Not tainted 2.6.31-rc9 #51 > Call Trace: > [] warn_slowpath_common+0x65/0x7c > [] ? __list_add+0x27/0x5c > [] warn_slowpath_fmt+0x24/0x27 > [] __list_add+0x27/0x5c > [] list_add+0xa/0xc > [] trace_add_event_call+0x60/0x97 > [] command_trace_probe+0x42c/0x51b > [] ? remove_wait_queue+0x22/0x27 > [] ? __wake_up+0x32/0x3b > [] probes_write+0xd4/0x10a > [] ? probes_write+0x0/0x10a > [] vfs_write+0x80/0xdf > [] sys_write+0x3b/0x5d > [] syscall_call+0x7/0xb > ---[ end trace 2b962b5dc1fdc07d ]--- > > Signed-off-by: Masami Hiramatsu