From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2882 invoked by alias); 13 Nov 2009 12:56:40 -0000 Received: (qmail 2875 invoked by uid 22791); 13 Nov 2009 12:56:40 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SARE_SUB_OBFU_Q0,SARE_SUB_OBFU_Q1,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Nov 2009 12:56:34 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nADCuT8L022993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 13 Nov 2009 07:56:29 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nADCuQTo024132; Fri, 13 Nov 2009 07:56:28 -0500 Subject: Re: Tapset for probing IRQs, workqueues, etc From: Mark Wielaard To: Prerna Saxena Cc: Josh Stone , systemtap@sourceware.org, David Smith In-Reply-To: <4AF7B2FA.5010506@linux.vnet.ibm.com> References: <4AE1E981.9050002@linux.vnet.ibm.com> <4AE602B6.7080809@redhat.com> <4AE9BAFB.70800@linux.vnet.ibm.com> <4AEA21C6.8000303@redhat.com> <4AF7B2FA.5010506@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 13 Nov 2009 12:56:00 -0000 Message-Id: <1258116986.6139.10.camel@hermans.wildebeest.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00505.txt.bz2 Hi Prerna, On Mon, 2009-11-09 at 11:43 +0530, Prerna Saxena wrote: > On 10/30/2009 04:44 AM, Josh Stone wrote: > > On 10/29/2009 08:55 AM, Prerna Saxena wrote: > >> I have not included the flags string on purpose for this probe point, > >> cos I think that one might need to look up the flags in specific > >> debugging scenarios only. It would not be required in most commonly used > >> cases, such as the attached example. However, I have documented the > >> function both inline in the tapset documentation and also in the man > >> pages, so that a script developer wanting to display a formatted string > >> can call the function when needed. > > > > It wouldn't hurt to have the tapset provide it as something like > > flags_str. That makes it more obvious for the user, and our optimizer > > should remove it automatically if it's not used. > > > Thanks! > Fixed in commit a476086d1ef0448c86e466f5955f78d282b473fd for new IRQ tapset. That commit calls irqflag_str() in the tapset/irq.stp, but didn't add the function itself. I assume you have it locally in aux_syscalls.stp. Could you commit that also? Thanks, Mark