From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22133 invoked by alias); 16 Nov 2009 09:38:10 -0000 Received: (qmail 22126 invoked by uid 22791); 16 Nov 2009 09:38:09 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SARE_SUB_OBFU_Q0,SARE_SUB_OBFU_Q1,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Nov 2009 09:37:05 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAG9b38l012154 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Nov 2009 04:37:03 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAG9b16H022215; Mon, 16 Nov 2009 04:37:02 -0500 Subject: Re: Tapset for probing IRQs, workqueues, etc From: Mark Wielaard To: Prerna Saxena Cc: Josh Stone , systemtap@sourceware.org, David Smith In-Reply-To: <4B00EA9E.7080403@linux.vnet.ibm.com> References: <4AE1E981.9050002@linux.vnet.ibm.com> <4AE602B6.7080809@redhat.com> <4AE9BAFB.70800@linux.vnet.ibm.com> <4AEA21C6.8000303@redhat.com> <4AF7B2FA.5010506@linux.vnet.ibm.com> <1258116986.6139.10.camel@hermans.wildebeest.org> <4B00EA9E.7080403@linux.vnet.ibm.com> Content-Type: text/plain Date: Mon, 16 Nov 2009 09:38:00 -0000 Message-Id: <1258364221.4763.6.camel@springer.wildebeest.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00530.txt.bz2 On Mon, 2009-11-16 at 11:31 +0530, Prerna Saxena wrote: > Thanks for pointing it out.. No problem. You added a testcase, it failed. So easy to detect :) > I guess my patch hadnt applied cleanly ! > I've added this via commit dc5a95301448c26bc016ebc618a8038e531d85f0 Thanks. I added one small workaround for kernel < 2.6.32 (which isn't actually released yet) which don't have IRQF_ONESHOT. With that everything passes also on my systems. Cheers, Mark >From 7b76473cbad92366721defee51d93396cb101134 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Mon, 16 Nov 2009 10:33:20 +0100 Subject: [PATCH] Define IRQF_ONESHOT for older kernels. IRQF_ONESHOT was only introduced in 2.6.32. It doesn't hurt defining it if it isn't already there. It will just never show up on older kernels. * tapset/aux_syscalls.stp: Define IRQF_ONESHOT if not already defined. --- tapset/aux_syscalls.stp | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tapset/aux_syscalls.stp b/tapset/aux_syscalls.stp index d544472..5435d3a 100644 --- a/tapset/aux_syscalls.stp +++ b/tapset/aux_syscalls.stp @@ -1900,6 +1900,9 @@ function _struct_sigaction32_u:string(uaddr:long) %{ #include +#ifndef IRQF_ONESHOT +#define IRQF_ONESHOT 0x00002000 +#endif static const _stp_val_array const _stp_irq_list[] = { V(IRQF_DISABLED), V(IRQF_SAMPLE_RANDOM), -- 1.6.2.5