From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-17329-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 3127 invoked by alias); 27 Jan 2011 10:40:49 -0000
Received: (qmail 3114 invoked by uid 22791); 27 Jan 2011 10:40:47 -0000
X-SWARE-Spam-Status: No, hits=-3.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from casper.infradead.org (HELO casper.infradead.org) (85.118.1.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Jan 2011 10:40:43 +0000
Received: from j77219.upc-j.chello.nl ([24.132.77.219] helo=laptop)	by casper.infradead.org with esmtpsa (Exim 4.72 #1 (Red Hat Linux))	id 1PiPH7-0003Ng-0w; Thu, 27 Jan 2011 10:40:25 +0000
Received: by laptop (Postfix, from userid 1000)	id 990711006DE10; Thu, 27 Jan 2011 11:41:17 +0100 (CET)
Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 5/20]  5: Uprobes: register/unregister probes.
From: Peter Zijlstra <peterz@infradead.org>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>, Linux-mm <linux-mm@kvack.org>, Arnaldo Carvalho de Melo <acme@infradead.org>, Linus Torvalds <torvalds@linux-foundation.org>, Ananth N Mavinakayanahalli <ananth@in.ibm.com>,  Christoph Hellwig <hch@infradead.org>, Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,  Oleg Nesterov <oleg@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, SystemTap <systemtap@sources.redhat.com>, Jim Keniston <jkenisto@linux.vnet.ibm.com>,  Frederic Weisbecker <fweisbec@gmail.com>, Andi Kleen <andi@firstfloor.org>, LKML <linux-kernel@vger.kernel.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
In-Reply-To: <20110127102527.GT19725@linux.vnet.ibm.com>
References:	 <20101216095817.23751.76989.sendpatchset@localhost6.localdomain6>	 <1295957744.28776.722.camel@laptop>	 <20110126075558.GB19725@linux.vnet.ibm.com>	 <1296036708.28776.1138.camel@laptop>	 <20110126153036.GN19725@linux.vnet.ibm.com>	 <1296056756.28776.1247.camel@laptop>	 <20110126165645.GP19725@linux.vnet.ibm.com>	 <1296061949.28776.1343.camel@laptop>	 <20110127100157.GS19725@linux.vnet.ibm.com>	 <1296123817.15234.57.camel@laptop>	 <20110127102527.GT19725@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 27 Jan 2011 10:40:00 -0000
Message-ID: <1296124877.15234.76.camel@laptop>
Mime-Version: 1.0
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2011-q1/txt/msg00164.txt.bz2

On Thu, 2011-01-27 at 15:55 +0530, Srikar Dronamraju wrote:
>=20
>=20
> If its not at the exact same location, then our third validation of
> checking that (vaddr =3D=3D vma->vm_start + uprobe->offset)  should fail
> right?
>=20
> Also should it be (vaddr =3D=3D uprobe->offset + vma->vm_start -
> vma->pgoff << PAGE_SHIFT) ?

Yeah, although I just realized that ->offset should be a u64, since
pgoff is a unsigned long, we can have files up to 44 bit (assuming the
page-size is 12bits).

But yes, this matches the validation I mentioned.