From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22649 invoked by alias); 14 Mar 2011 15:29:17 -0000 Received: (qmail 22628 invoked by uid 22791); 14 Mar 2011 15:29:15 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from hrndva-omtalb.mail.rr.com (HELO hrndva-omtalb.mail.rr.com) (71.74.56.125) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 15:29:11 +0000 X-Authority-Analysis: v=1.1 cv=3uSaImBeuprzHBlOOPjkqgu+7PcxSRW0m2Aphm9Zmck= c=1 sm=0 a=NhuigFM5MhYA:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=gHhx2tW0LaDl3lk1CoEA:9 a=2qVoUX2Bhxc_E71021c06H6PzCUA:4 a=PUjeQqilurYA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 Received: from [67.242.120.143] ([67.242.120.143:34111] helo=[192.168.23.10]) by hrndva-oedge04.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id B2/03-04612-2443E7D4; Mon, 14 Mar 2011 15:29:09 +0000 Subject: Re: [PATCH v2 2.6.38-rc8-tip 3/20] 3: uprobes: Breakground page replacement. From: Steven Rostedt To: Srikar Dronamraju Cc: Peter Zijlstra , Ingo Molnar , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Ananth N Mavinakayanahalli , Christoph Hellwig , Andi Kleen , Masami Hiramatsu , Oleg Nesterov , LKML , Jim Keniston , Roland McGrath , SystemTap , Andrew Morton , "Paul E. McKenney" In-Reply-To: <20110314133433.27435.49566.sendpatchset@localhost6.localdomain6> References: <20110314133403.27435.7901.sendpatchset@localhost6.localdomain6> <20110314133433.27435.49566.sendpatchset@localhost6.localdomain6> Content-Type: text/plain; charset="ISO-8859-15" Date: Mon, 14 Mar 2011 15:29:00 -0000 Message-ID: <1300116546.9910.107.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q1/txt/msg00372.txt.bz2 On Mon, 2011-03-14 at 19:04 +0530, Srikar Dronamraju wrote: > +/* > + * Most architectures can use the default versions of @read_opcode(), > + * @set_bkpt(), @set_orig_insn(), and @is_bkpt_insn(); > + * > + * @set_ip: > + * Set the instruction pointer in @regs to @vaddr. > + * @analyze_insn: > + * Analyze @user_bkpt->insn. Return 0 if @user_bkpt->insn is an > + * instruction you can probe, or a negative errno (typically -%EPERM) > + * otherwise. Determine what sort of sort of ... what? -- Steve > + * @pre_xol: > + * @post_xol: > + * XOL-related fixups @post_xol() (and possibly @pre_xol()) will need > + * to do for this instruction, and annotate @user_bkpt accordingly. > + * You may modify @user_bkpt->insn (e.g., the x86_64 port does this > + * for rip-relative instructions). > + */