From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-17820-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 23112 invoked by alias); 19 Apr 2011 13:12:41 -0000
Received: (qmail 23044 invoked by uid 22791); 19 Apr 2011 13:12:41 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,TW_JL
X-Spam-Check-By: sourceware.org
Received: from hrndva-omtalb.mail.rr.com (HELO hrndva-omtalb.mail.rr.com) (71.74.56.124)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 13:12:25 +0000
X-Authority-Analysis: v=1.1 cv=aqMe+0lCtaYvy4h0jyaoPGyq+DPF+P6rPG2xbekoY9Q= c=1 sm=0 a=ivMq54vb1cIA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=AvZSfK5FebFRBBOED8oA:9 a=PUjeQqilurYA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117
Received: from [67.242.120.143] ([67.242.120.143:38446] helo=[192.168.23.10])	by hrndva-oedge01.mail.rr.com (envelope-from <rostedt@goodmis.org>)	(ecelerity 2.2.3.46 r()) with ESMTP	id 04/60-20102-63A8DAD4; Tue, 19 Apr 2011 13:12:24 +0000
Subject: Re: [PATCH v3 2.6.39-rc1-tip 15/26] 15: uprobes: Handing int3 and singlestep exception.
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>, Ingo Molnar <mingo@elte.hu>,  Linux-mm <linux-mm@kvack.org>, Arnaldo Carvalho de Melo <acme@infradead.org>, Linus Torvalds <torvalds@linux-foundation.org>, Jonathan Corbet <corbet@lwn.net>, Christoph Hellwig <hch@infradead.org>, Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>, Thomas Gleixner <tglx@linutronix.de>, Ananth N Mavinakayanahalli <ananth@in.ibm.com>, Oleg Nesterov <oleg@redhat.com>, LKML <linux-kernel@vger.kernel.org>, SystemTap <systemtap@sources.redhat.com>, Jim Keniston <jkenisto@linux.vnet.ibm.com>, Roland McGrath <roland@hack.frob.com>, Andi Kleen <andi@firstfloor.org>, Andrew Morton <akpm@linux-foundation.org>
In-Reply-To: <1303218185.8345.0.camel@twins>
References:	 <20110401143223.15455.19844.sendpatchset@localhost6.localdomain6>	 <20110401143527.15455.32854.sendpatchset@localhost6.localdomain6>	 <1303218185.8345.0.camel@twins>
Content-Type: text/plain; charset="ISO-8859-15"
Date: Tue, 19 Apr 2011 13:12:00 -0000
Message-ID: <1303218742.7181.96.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2011-q2/txt/msg00112.txt.bz2

On Tue, 2011-04-19 at 15:03 +0200, Peter Zijlstra wrote:
> On Fri, 2011-04-01 at 20:05 +0530, Srikar Dronamraju wrote:
> > +       if (unlikely(!utask)) {
> > +               utask = add_utask();
> > +
> > +               /* Failed to allocate utask for the current task. */
> > +               BUG_ON(!utask);
> 
> That's not really nice is it ;-) means I can make the kernel go BUG by
> simply applying memory pressure.

Agreed,

None of these patches should have a single BUG_ON(). They all must fail
nicely.

-- Steve

> 
> > +               utask->state = UTASK_BP_HIT;
> > +       }