From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29535 invoked by alias); 20 Jul 2011 14:13:17 -0000 Received: (qmail 29525 invoked by uid 22791); 20 Jul 2011 14:13:16 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 14:12:49 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6KECn4q030198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Jul 2011 10:12:49 -0400 Received: from springer.wildebeest.org (ovpn-113-105.phx2.redhat.com [10.3.113.105]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6KEClEd025441 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 20 Jul 2011 10:12:48 -0400 Received: by springer.wildebeest.org (Postfix, from userid 500) id 5F8B340AA9; Wed, 20 Jul 2011 16:12:46 +0200 (CEST) Subject: Re: Making the transport layer more robust From: Mark Wielaard To: systemtap@sourceware.org In-Reply-To: <1311065908.9144.27.camel@springer.wildebeest.org> References: <1311065908.9144.27.camel@springer.wildebeest.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Wed, 20 Jul 2011 14:13:00 -0000 Message-ID: <1311171165.5022.2.camel@springer.wildebeest.org> Mime-Version: 1.0 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00064.txt.bz2 On Tue, 2011-07-19 at 10:58 +0200, Mark Wielaard wrote: > I am still investigating the test results on > rhel5, they don't look that good (in particular exelib.exp fails a lot > of tests because it is unable to find process.mark probe points) Finally tracked this down to an old binutils bug... sigh. When I finally knew what it was, the fix was was easy. With this all the 188 exelib.exp tests PASS also on rhel5 based systems. Cheers, Mark commit 1189063f8adaa13e2da16b51ab665663497ac102 Author: Mark Wielaard Date: Wed Jul 20 16:05:31 2011 +0200 Always look for .note.stapsdt sections in the main elf file. =20=20=20=20 In dwflpp::iterate_over_notes we really want the actual elf file, not the dwarf .debug file. Older binutils had a bug where they mangled the SHT_NOTE type during --keep-debug. diff --git a/dwflpp.cxx b/dwflpp.cxx index fcc142b..2ab8772 100644 --- a/dwflpp.cxx +++ b/dwflpp.cxx @@ -1007,8 +1007,10 @@ int dwflpp::iterate_over_notes (void *object, void (*callback)(void *object, i= nt type, const char *data, size_t len)) { Dwarf_Addr bias; - Elf* elf =3D (dwarf_getelf (dwfl_module_getdwarf (module, &bias)) - ?: dwfl_module_getelf (module, &bias)); + // Note we really want the actual elf file, not the dwarf .debug file. + // Older binutils had a bug where they mangled the SHT_NOTE type during + // --keep-debug. + Elf* elf =3D dwfl_module_getelf (module, &bias); size_t shstrndx; if (elf_getshdrstrndx (elf, &shstrndx)) return elf_errno();