From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25770 invoked by alias); 21 Oct 2011 15:02:56 -0000 Received: (qmail 25754 invoked by uid 22791); 21 Oct 2011 15:02:54 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Oct 2011 15:02:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9LF2bSj014919 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Oct 2011 11:02:37 -0400 Received: from springer.wildebeest.org (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9LF2Zql031149 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 21 Oct 2011 11:02:37 -0400 Received: by springer.wildebeest.org (Postfix, from userid 500) id 6BBCF47122; Fri, 21 Oct 2011 17:02:35 +0200 (CEST) Subject: Re: Enabling dwarf unwinder for ppc64 From: Mark Wielaard To: systemtap@sourceware.org In-Reply-To: <1319205269.1087.26.camel@springer.wildebeest.org> References: <1317986514.3351.26.camel@springer.wildebeest.org> <1318544454.17642.24.camel@springer.wildebeest.org> <1319121395.15833.42.camel@springer.wildebeest.org> <1319204074.1087.23.camel@springer.wildebeest.org> <1319205269.1087.26.camel@springer.wildebeest.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Fri, 21 Oct 2011 15:02:00 -0000 Message-ID: <1319209354.1087.31.camel@springer.wildebeest.org> Mime-Version: 1.0 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q4/txt/msg00093.txt.bz2 On Fri, 2011-10-21 at 15:54 +0200, Mark Wielaard wrote: > On Fri, 2011-10-21 at 15:34 +0200, Mark Wielaard wrote: > > Host: Linux ibm-ps701-01-lp2.rhts.eng.bos.redhat.com > > 2.6.32-209.el6.ppc64 #1 SMP Wed Oct 12 03:52:18 EDT 2011 ppc64 ppc64 > > ppc64 GNU/Linux > > Snapshot: version 1.7/0.152 commit release-1.6-340-gb100897 > > GCC: 4.4.6 [gcc (GCC) 4.4.6 20110731 (Red Hat 4.4.6-3)] > > Distro: Red Hat Enterprise Linux Server release 6.2 Beta (Santiago) > >=20 > > # of expected passes 2893 > > # of unexpected failures 127 > > # of unexpected successes 9 > > # of expected failures 255 > > # of untested testcases 65 > > # of unsupported tests 6 > >=20 > > About 100 of the unexpected failures are in the systemtap.unprivileged > > testsuite, which I haven't investigated yet. >=20 > While investigating, I found the following in > testsuite/systemtap.unprivileged/unprivileged_myproc.exp >=20 > # ppc64 needs a more restrictive constraint for the probe args > if {[regexp "^(x86_64|i.86)$" $::tcl_platform(machine)] =3D=3D 0} { > set exeflags "$exeflags additional_flags=3D-DSTAP_SDT_ARG_CONSTRAINT=3Dnr" > } >=20 > But (removing) that doesn't seem to change any of the results it seems. > What is that used for? I still haven't figured out what that is for, so I just left it in for now. The actual issue was more mundane. On powerpc function symbols start with a '.', so the address extraction in those testcases failed. Fixed as follows: commit 50c8dc801a8fd22a3f6b8fd00e5d29944dfffbab Author: Mark Wielaard Date: Fri Oct 21 16:49:02 2011 +0200 Extract addr_of for unprivileged_[my]probes.exp once and with optional dot. =20=20=20=20 Some architectures prefix function symbols with a '.', so accept an optional dot prefix. Also extract each symbol only once instead of for each pass over the list. With that both x86_64 and ppc64 give the same number of failures for the systemtap.unprivileged testsuites: Running /home/mark/src/systemtap/testsuite/systemtap.unprivileged/unprivile= ged_embedded_C.exp ... Running /home/mark/src/systemtap/testsuite/systemtap.unprivileged/unprivile= ged_myproc.exp ... FAIL: unprivileged myproc: not tested: process(string).library(string).plt FAIL: unprivileged myproc: not tested: process(string).library(string).plt.= statement(number) FAIL: unprivileged myproc: not tested: process(string).library(string).plt(= string) FAIL: unprivileged myproc: not tested: process(string).library(string).plt(= string).statement(number) FAIL: unprivileged myproc: not tested: process(string).plt FAIL: unprivileged myproc: not tested: process(string).plt.statement(number) FAIL: unprivileged myproc: not tested: process(string).plt(string) FAIL: unprivileged myproc: not tested: process(string).plt(string).statemen= t(number) Running /home/mark/src/systemtap/testsuite/systemtap.unprivileged/unprivile= ged_probes.exp ... FAIL: unprivileged probes: not tested: process(string).library(string).plt FAIL: unprivileged probes: not tested: process(string).library(string).plt.= statement(number) FAIL: unprivileged probes: not tested: process(string).library(string).plt(= string) FAIL: unprivileged probes: not tested: process(string).library(string).plt(= string).statement(number) FAIL: unprivileged probes: not tested: process(string).plt FAIL: unprivileged probes: not tested: process(string).plt.statement(number) FAIL: unprivileged probes: not tested: process(string).plt(string) FAIL: unprivileged probes: not tested: process(string).plt(string).statemen= t(number) Cheers, Mark