public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mjw@redhat.com>
To: Negreanu Marius Adrian <adrian.m.negreanu@intel.com>
Cc: systemtap@sourceware.org
Subject: Re: [PATCH] add dbug_task_vma debug macro
Date: Mon, 14 May 2012 10:16:00 -0000	[thread overview]
Message-ID: <1336990553.3015.28.camel@springer.wildebeest.org> (raw)
In-Reply-To: <1336833118-19175-1-git-send-email-adrian.m.negreanu@intel.com>

On Sat, 2012-05-12 at 17:31 +0300, Negreanu Marius Adrian wrote:
> replace DEBUG_TASK_FINDER_VMA
> with a dbug_unwind-like macro: dbug_task_vma
> ---
>  runtime/debug.h          |   10 ++++++++++
>  runtime/task_finder.c    |    8 ++------
>  runtime/task_finder2.c   |    8 ++------
>  runtime/uprobes-common.c |   20 +++++---------------
>  runtime/vma.c            |   40 ++++++++++------------------------------
>  5 files changed, 29 insertions(+), 57 deletions(-)

Thanks, that is much nicer than the scattered #if
defined(DEBUG_TASK_FINDER_VMA) throughout the source. Pushed.

There is also the plain DEBUG_TASK_FINDER (all non-vma stuff) that could
be done in the same way.

Thanks,

Mark

      reply	other threads:[~2012-05-14 10:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-12 14:31 Negreanu Marius Adrian
2012-05-14 10:16 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336990553.3015.28.camel@springer.wildebeest.org \
    --to=mjw@redhat.com \
    --cc=adrian.m.negreanu@intel.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).