From: Pasi Savanainen <pasi.savanainen@nixu.com>
To: systemtap@sourceware.org
Subject: [PATCH] Removed unneeded access().
Date: Wed, 13 Jun 2012 12:01:00 -0000 [thread overview]
Message-ID: <1339588861-27950-1-git-send-email-pasi.savanainen@nixu.fi> (raw)
* ctl.c: access() is not needed because previous open() will fail
if user has no read write accees to a command channel file.
Actually existance of access() check generates a misleading error:
"Error, 'stap_26013' (stap_26013) is not a zombie systemtap module."
when stap is runned by regular user (stapusr group)
and /sys/kernel/debug is mounted as 0700.
---
runtime/staprun/ctl.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/runtime/staprun/ctl.c b/runtime/staprun/ctl.c
index 1ffc8e3..96c140d 100644
--- a/runtime/staprun/ctl.c
+++ b/runtime/staprun/ctl.c
@@ -30,15 +30,6 @@ int init_ctl_channel(const char *name, int verb)
control_channel = open(buf, O_RDWR);
dbug(2, "Opened %s (%d)\n", buf, control_channel);
-/* It's actually safe to do this check before the open(),
- * as the file we're trying to access connot be modified
- * by a typical user.
- */
- if (access(buf, R_OK|W_OK) != 0){
- close(control_channel);
- return -5;
- }
-
if (control_channel < 0) {
if (verb) {
if (attach_mod && errno == ENOENT)
--
1.7.5.4
next reply other threads:[~2012-06-13 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 12:01 Pasi Savanainen [this message]
2012-06-13 17:13 ` Josh Stone
2012-06-14 6:39 ` Pasi Savanainen
2012-06-14 21:32 ` Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339588861-27950-1-git-send-email-pasi.savanainen@nixu.fi \
--to=pasi.savanainen@nixu.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).