From: David Smith <dsmith@redhat.com>
To: Rajasekhar Duddu <rajduddu@linux.vnet.ibm.com>
Cc: systemtap@sources.redhat.com
Subject: Re: [PATCH V5] Tracepoint Tapset for Memory Subsystem
Date: Fri, 04 Dec 2009 17:11:00 -0000 [thread overview]
Message-ID: <1345668408.1559141259946693147.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <449125467.1554931259945048608.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com>
One really minor comment below.
> ----- Original Message -----
> From: "Rajasekhar Duddu" <rajduddu@linux.vnet.ibm.com>
> To: systemtap@sources.redhat.com
> Sent: Friday, December 4, 2009 6:08:19 AM GMT -06:00 US/Canada Central
> Subject: Re: [PATCH V5] Tracepoint Tapset for Memory Subsystem
>
>
> Hi all,
> I have update the patch according to Franks previous
> comments.
> Please review it and if it is fine, please somebody commit this
> version of patch on behalf of me..thanks in advance.
>
>
> +probe __vm.kmalloc.tp = kernel.trace("kmalloc") {
> + name = "kmalloc"
> + call_site = $call_site
> + caller_function = symname(call_site)
> + bytes_req = $bytes_req
> + bytes_alloc = $bytes_alloc
> + gfp_flags = $gfp_flags
> + gfp_flag_name = __gfp_flag_str($gfp_flags)
> + ptr = $ptr
> +}
> +
> +/* It is unsafe to invoke __builtin_return_address() \
> +presently(to get call_site for kporbe based probes) \
> +and that it can be improved later when fix for bugs bz#6961 and bz#6580 is available. */
Typo here - 'kporbe' should be 'kprobe'.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
next parent reply other threads:[~2009-12-04 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <449125467.1554931259945048608.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com>
2009-12-04 17:11 ` David Smith [this message]
2009-12-09 6:59 ` Rajasekhar Duddu
2009-11-25 9:31 [PATCH V4] " Rajasekhar Duddu
2009-11-30 16:26 ` Frank Ch. Eigler
2009-12-04 12:09 ` [PATCH V5] " Rajasekhar Duddu
2009-12-07 2:52 ` Wenji Huang
2009-12-09 6:57 ` Rajasekhar Duddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345668408.1559141259946693147.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com \
--to=dsmith@redhat.com \
--cc=rajduddu@linux.vnet.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).