From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21084 invoked by alias); 7 Nov 2014 14:43:39 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 20948 invoked by uid 89); 7 Nov 2014 14:43:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f54.google.com Received: from mail-pa0-f54.google.com (HELO mail-pa0-f54.google.com) (209.85.220.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 07 Nov 2014 14:43:36 +0000 Received: by mail-pa0-f54.google.com with SMTP id rd3so3600121pab.41 for ; Fri, 07 Nov 2014 06:43:34 -0800 (PST) X-Received: by 10.68.87.37 with SMTP id u5mr12420653pbz.128.1415371414862; Fri, 07 Nov 2014 06:43:34 -0800 (PST) Received: from [116.40.193.38] ([116.40.193.38]) by mx.google.com with ESMTPSA id g8sm4485876pdn.80.2014.11.07.06.43.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 07 Nov 2014 06:43:34 -0800 (PST) Subject: Re: [RFC] perf-cache command interface design From: Namhyung Kim To: Masami Hiramatsu Cc: Hemant Kumar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com, peterz@infradead.org, oleg@redhat.com, hegdevasant@linux.vnet.ibm.com, mingo@redhat.com, systemtap@sourceware.org, aravinda@linux.vnet.ibm.com, penberg@iki.fi, brendan.d.gregg@gmail.com, "yrl.pp-manager.tt@hitachi.com" In-Reply-To: <545C80F4.4020905@hitachi.com> References: <20141102105006.21708.28734.stgit@hemant-fedora> <20141102105557.21708.19032.stgit@hemant-fedora> <87lhnr5sbl.fsf@sejong.aot.lge.com> <54588905.7040002@linux.vnet.ibm.com> <5458CD15.4010101@hitachi.com> <874muew2hk.fsf@sejong.aot.lge.com> <5459E865.6050207@hitachi.com> <545B1DDE.9000202@linux.vnet.ibm.com> <545C80F4.4020905@hitachi.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 07 Nov 2014 14:43:00 -0000 Message-ID: <1415371407.1648.37.camel@leonhard> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SW-Source: 2014-q4/txt/msg00123.txt.bz2 Hi Masami, 2014-11-07 (금), 17:21 +0900, Masami Hiramatsu: > Hello, > > Here, I've tried to describe my idea of perf-cache subcommand interface. > It is just a design review, not implemented yet :) > Please give me your comments/ideas! > > Command-line Synopsis > ===================== > > Current "perf buildid-cache [options]" are directly mapped to > "perf cache --buildid [options]". > > And adding --sdt for managing SDT caches as below. > > Add or update SDT events in > perf cache --sdt --add|--update > > Remove all SDT events for > perf cache --sdt --remove > > List all SDT events > perf cache --sdt --list > > And --probes for managing probe-caches as below. > > Add new probe-cache entries for kernel, or . > perf cache --probe [--exec |--module ] --add > > Delete existing probe-cache entries for kernel, or/and . > perf cache --probe --del [:][@][#] > > Or remove all entires for given FILES > perf cache --probe --remove > > List the probe caches(including SDT) for kernel, , or/and . > perf cache --probe --list [@][#] > > Query the probe definitions. > perf cache --probe --query [:][@][#] > > Note that --probes also can be used for managing SDT events, which has % prefix > e.g. > Add all SDT events for > perf cache --probe --exec --add '%*:*' > > Remove some SDT events for > perf cache --probe --del '%some:events@' > > Or remove all SDT events for > perf cache --probe --del '%*:*#' I'd prefer sub-command to option for this mandatory (and exclusive) behavior. What about like this? perf cache kprobe add [-m ] [...] perf cache kprobe del [:] [...] perf cache kprobe list [-m ] perf cache uprobe add -x [...] perf cache uprobe del [:] [...] perf cache uprobe list [-x ] perf cache sdt [add|del|update] [...] perf cache sdt list [-b ] [...] > > > File Format > =========== > All the cache files are placed under ~/.debug/ by default. > The paths of buildid cache of binary/symbols are not changed. > > The SDT/probe caches are placed under the ~/.debug/.probes/path/to/bin/bu/ildid > and that is linked to ~/.debug/.probes/.buildid/bu/ildid > # To avoid conflict with files under /probes/*, I picked up .probes/. However, to be used with perf record, we need a way to find a matching probe cache file from a event name (or group/provider name, preferably). What about having something like below: $ cat ~/.debug/.probes/event.map PROVIDER1 /path/to/some/where PROVIDER2 /path/to/other/place When perf record see a cached event used, it first searches its provider/group name from the event.map file. And then read bulid-id from the matching file on the path and finally find a cached event definition from ~/.debug/.probes/.buildid/bu/ildid file. > > This SDT/probe caches contain probe-definitions as following format. > ---- > #buildid:BUILDID > #path:PATH > p:%PROVIDER/EVENT PATH:OFFSET [ARGS] It seems PATH is redundant and we don't need to repeat it everyline IMHO. Since it need post-processing anyway, maybe it's better to just make it simpler, like: %:PROVIDER/EVENT OFFSET [ARGS] Thanks, Namhyung > p:PROBE/EVENT _text+OFFSET [ARGS] > ---- > > Normal probes and SDT cache entries can be mixed in a cache file, we'll > load all the entries and filter by % prefixes. > > > Thank you, >