master's current HEAD still uses file->f_dentry, removed in Linux 3.19

master's current HEAD still uses file->f_dentry, removed in Linux 3.19

[Giovanni Gherdovich]

Hello,

was this patch from William Cohen (Dec 2014)
https://sourceware.org/ml/systemtap/2014-q4/msg00257.html
ever applied?

I cloned from git://sourceware.org/git/systemtap.git, and on the tag
release-3.0 (two weeks ago) grepping for f_dentry on the file
runtime/linux/task_finder2.c still gives results.

f_dentry was a macro defined in the Linux kernel (precisely,
include/linux/fs.h) removed in the 3.19 release. With the SystemTap
version I have, even a minimal test script like

stap -ve 'probe begin { log("hello world") exit () }'

fails compilation with

error: 'struct file' has no member named 'f_dentry'

The patch I link above fixes this, but I can't find traces of it in the
git history. Is there something I'm missing?

Regards,
Giovanni

Re: master's current HEAD still uses file->f_dentry, removed in Linux 3.19

[Giovanni Gherdovich]

On Fri, 2016-04-15 at 11:35 +0200, Giovanni Gherdovich wrote:
> 
> [...] With the SystemTap
> version I have, even a minimal test script like
> 
> stap -ve 'probe begin { log("hello world") exit () }'
> 
> fails compilation with
> 
> error: 'struct file' has no member named 'f_dentry'

Sorry, my bad.
I was running SystemTap 2.5; I upgraded to 3.0 and the problem if
fixed.

The rev I missed is

commit: 547f6291433b574186e82f4afe233b00b7eb242e
date: Tue, 6 Jan 2015 10:07:01 -0600
title: Fixed compile problem on 3.18 kernels, caused by removal of
       dentry macro.
https://sourceware.org/git/?p=systemtap.git;a=commit;h=547f6291433b5741
86e82f4afe233b00b7eb242e

appeared in 2.7.

Regards,
Giovanni