public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "faicker.mo" <faicker.mo@ucloud.cn>
To: systemtap@sourceware.org
Cc: "faicker.mo" <faicker.mo@ucloud.cn>
Subject: [PATCH] buildrun: no sanitize $PATH for kbuild invocation
Date: Fri, 21 Dec 2018 08:10:00 -0000	[thread overview]
Message-ID: <1545379729-30048-1-git-send-email-faicker.mo@ucloud.cn> (raw)

From: "faicker.mo" <faicker.mo@ucloud.cn>

For newer kernel, SCL with newer gcc and systemtap prepends
it's directory to the $PATH to take effect.  It doesn't work
if $PATH is sanitized (prefixed with /usr/bin:/bin:)

Fixes e8474d2a

Signed-off-by: faicker.mo <faicker.mo@ucloud.cn>
---
 buildrun.cxx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildrun.cxx b/buildrun.cxx
index cef14ad..dcdb6e8 100644
--- a/buildrun.cxx
+++ b/buildrun.cxx
@@ -99,7 +99,7 @@ make_any_make_cmd(systemtap_session& s, const string& dir, const string& target)
   const char *oldpath = getenv("PATH");
   if (oldpath != NULL)
     {
-      newpath += ':';
+      newpath = "PATH=";
       newpath += oldpath;
     }
 
-- 
1.8.3.1

             reply	other threads:[~2018-12-21  8:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-21  8:10 faicker.mo [this message]
2018-12-26  9:53 ` wyang
2018-12-28  7:10   ` Faicker Mo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1545379729-30048-1-git-send-email-faicker.mo@ucloud.cn \
    --to=faicker.mo@ucloud.cn \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).