From: Paul Mackerras <paulus@samba.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Ingo Molnar <mingo@redhat.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Christoph Hellwig <hch@infradead.org>,
"Martin J. Bligh" <mbligh@mbligh.org>,
linuxppc-dev@ozlabs.org,
Douglas Niehaus <niehaus@eecs.ku.edu>,
ltt-dev@shafik.org, systemtap@sources.redhat.com,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 7/10] local_t : powerpc
Date: Wed, 24 Jan 2007 10:00:00 -0000 [thread overview]
Message-ID: <17847.8700.118329.777644@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20061221002705.GW28643@Krystal>
Mathieu Desnoyers writes:
> +static __inline__ int local_dec_if_positive(local_t *l)
> +{
> + int t;
> +
> + __asm__ __volatile__(
> +"1: lwarx %0,0,%1 # local_dec_if_positive\n\
> + addic. %0,%0,-1\n\
> + blt- 2f\n"
> + PPC405_ERR77(0,%1)
> +" stwcx. %0,0,%1\n\
> + bne- 1b"
This has the same bugs that we fixed recently in atomic_dec_if_positive;
first, on 64-bit machines, the lwarx will zero-extend the word loaded
from memory, and so the result of the addic will be negative only if
the word was originally 0. Secondly, even on 32-bit machines,
0x80000000 will be considered positive since decrementing it gives
0x7fffffff, which is positive.
> +/* Use these for per-cpu local_t variables: on some archs they are
> + * much more efficient than these naive implementations. Note they take
> + * a variable, not an address.
> + *
> + * This could be done better if we moved the per cpu data directly
> + * after GS.
> + */
What's "GS"? Does this comment really apply on powerpc?
Paul.
next prev parent reply other threads:[~2007-01-24 10:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 0:22 [PATCH 0/10] local_t : adding and standardising atomic primitives Mathieu Desnoyers
2006-12-21 0:22 ` [PATCH 1/10] local_t : architecture agnostic Mathieu Desnoyers
2006-12-21 0:24 ` [PATCH 2/10] local_t : alpha Mathieu Desnoyers
2006-12-21 0:25 ` [PATCH 3/10] local_t : i386 Mathieu Desnoyers
2006-12-21 19:47 ` [Ltt-dev] [PATCH 3/10] local_t : i386, local_add_return fix Mathieu Desnoyers
2006-12-21 0:26 ` [PATCH 4/10] local_t : ia64 Mathieu Desnoyers
2006-12-21 0:27 ` [PATCH 6/10] local_t : parisc Mathieu Desnoyers
2006-12-21 0:27 ` [PATCH 5/10] local_t : ia64 Mathieu Desnoyers
2006-12-21 18:56 ` [Ltt-dev] [PATCH 5/10] local_t : MIPS Mathieu Desnoyers
2006-12-21 0:28 ` [PATCH 7/10] local_t : powerpc Mathieu Desnoyers
2006-12-21 14:04 ` [Ltt-dev] " Mathieu Desnoyers
2007-01-24 10:00 ` Paul Mackerras [this message]
2007-01-24 10:43 ` Gabriel Paubert
2007-01-24 17:05 ` Mathieu Desnoyers
2006-12-21 0:29 ` [PATCH 8/10] local_t : s390 Mathieu Desnoyers
2006-12-21 0:41 ` [PATCH 9/10] local_t : sparc64 Mathieu Desnoyers
2006-12-21 3:01 ` [PATCH 10/10] local_t : x86_64 Mathieu Desnoyers
2006-12-21 19:55 ` [Ltt-dev] [PATCH 10/10] local_t : x86_64 : local_add_return Mathieu Desnoyers
2006-12-26 19:48 ` [PATCH 0/10] local_t : adding and standardising atomic primitives Pavel Machek
2007-01-09 3:20 ` [PATCH] local_t : Documentation Mathieu Desnoyers
2007-01-09 21:02 ` Andrew Morton
2007-01-09 22:11 ` Mathieu Desnoyers
2007-01-09 22:12 ` Andrew Morton
2007-01-09 22:38 ` Pavel Machek
2007-01-09 22:41 ` Pavel Machek
2007-01-09 23:27 ` [PATCH] local_t : Documentation - update Mathieu Desnoyers
2007-01-09 23:45 ` Pavel Machek
2007-01-10 0:39 ` Mathieu Desnoyers
2007-01-10 1:06 ` [Ltt-dev] " Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17847.8700.118329.777644@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ltt-dev@shafik.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@mbligh.org \
--cc=mingo@redhat.com \
--cc=niehaus@eecs.ku.edu \
--cc=systemtap@sources.redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).