* syscall/errno tapset checkins
@ 2005-09-26 20:41 Frank Ch. Eigler
0 siblings, 0 replies; only message in thread
From: Frank Ch. Eigler @ 2005-09-26 20:41 UTC (permalink / raw)
To: systemtap
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
Hi, Kevin -
It's nice to see this code starting to appear in CVS. Some
suggestions. For errno.stp, you don't need to use relatively
inefficient embedded C like that. Consider instead an all-script
solution:
global _errno_table
probe begin {
_errno_table[1] = "EFOOBAR"
_errno_table[4] = "EBARBAZ"
// and so on
}
function strerror (e) { return _errno_table[e] }
Then any reference to the script function "strerror" will drag in the
initialization code as a side-effect.
Another suggestion. It would be nice to add a ChangeLog entry for
nontrivial commits such as these. It would be nice to add
stapfuncs(5) or stapprobes(5) documentation lines for the contents as
they settle down.
- FChE
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-09-26 20:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-09-26 20:41 syscall/errno tapset checkins Frank Ch. Eigler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).