public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@redhat.com>
To: systemtap@sources.redhat.com
Subject: PR 1295
Date: Tue, 27 Sep 2005 01:18:00 -0000	[thread overview]
Message-ID: <20050927011751.GI27733@redhat.com> (raw)

Hi -

I committed a possible improvement in the way prologues are analyzed
in systemtap.  Recall that this analysis is essential in order to
access function parameters based upon the limited location list
(debug) info that older gcc's produce.

This is a slightly different heuristic that overrides the previous
one.  This one looks for the first line record (roughly: object code
PC address of potential debugging interest) that has a source line
coordinate other than the one associated with the function entrypc.
The latter is usually assigned to the "{" opening brace.  The former
is usually the first real statement.  Comments inside tapsets.cxx
(resolve_prologue_endings2) indicate one possible problem with this
(not matching based on file name), which would benefit from a teeny
elfutils extension.

The previous heuristic worked by looking for the first line record
after the function decl's own.  Unfortunately, this fails if the
compiler happens to emit a few sort-of dummy records for activity
within the prologue.

Anyway, since this was one of my first forays into dwarf land, it's
quite possible that something is not quite right, so please retest any
script code that relies on accessing function parameters.  In
particular, if in verbose (-v) mode, there is a "prologue
disagreement" message, the new heuristic has taken over, and I'd like
to hear about it.

- FChE

                 reply	other threads:[~2005-09-27  1:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050927011751.GI27733@redhat.com \
    --to=fche@redhat.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).