public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@redhat.com>
To: Martin Hunt <hunt@redhat.com>
Cc: systemtap@sources.redhat.com
Subject: Re: MAXACTION exceeded error while using systemtap
Date: Wed, 07 Dec 2005 21:09:00 -0000	[thread overview]
Message-ID: <20051207210948.GH9617@redhat.com> (raw)
In-Reply-To: <1133988833.4007.20.camel@monkey2>

Hi -


hunt wrote:

> What I would like to see is MAXACTION set to a very low value in
> kprobes (or jprobes or djprobes). It would be equivalent to a couple
> of milliseconds, at most.

Could someone undertake an experiment to measure how long some
representative probes actually take?  If it turns out that we can fit
10**4 or even 10**5 "typical" systemtap statements within a small
amount of wall-clock time on a typical machine, then MAXACTION could
simply be bumped up to that number.

The current default MAXACTION value (1000) was picked within the
confines of the same data vacuum that we have within this discussion.


> It would prevent things like sorting and printing maps, no matter
> what their size. Theoretically we could allow these for very small
> maps, but why would we want to?

Well, because they may be necessary for some as-yet-unimagined probing
context.  The problem is not sorting per se, but the amount of time
that sorting (or anything else) takes.  If we were to impose
language-level restrictions, and someone still needed to sort/print
array pieces from within a kprobe, they'd just work around it.  They
can go and open-code a bubble sort in script language, a foreach/print
over the array.  I'm sure you agree this is not desirable.


> Rather than attempt to calculate how much time a potentially
> time-consuming function will really take [...]

I'm not suggesting that such a calculation need be precise enough to
be anything more than a trivial function of the subject map size.  It
just needs to be vaguely proportional to the cost, so we can keep to a
rough deadline.


> For timer events, MAXACTION would be very large. Large enough to
> sort any size arrays and print maybe 1000 lines or so.  For begin
> and end probes, MAXACTION would be something less than infinite so
> there are no infinite loops.

I believe this expresses the mistaken belief that deadlines are only
necessary for kprobes.


- FChE

  reply	other threads:[~2005-12-07 21:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-06 21:56 Stone, Joshua I
2005-12-06 22:11 ` Frank Ch. Eigler
2005-12-07 20:53   ` Martin Hunt
2005-12-07 21:09     ` Frank Ch. Eigler [this message]
2005-12-07 22:29       ` Martin Hunt
2005-12-07 23:07         ` Frank Ch. Eigler
2005-12-08  8:55           ` Martin Hunt
2005-12-08 12:52             ` James Dickens
2005-12-08 13:57               ` Frank Ch. Eigler
2005-12-28 19:06                 ` Marcelo Tosatti
2005-12-28 20:12                   ` Tom Zanussi
2005-12-28 20:38                     ` Marcelo Tosatti
2005-12-28 21:13                   ` Frank Ch. Eigler
2005-12-08 13:37             ` Frank Ch. Eigler
  -- strict thread matches above, loose matches on Subject: below --
2005-12-08 17:50 Stone, Joshua I
2005-12-06 20:41 Stone, Joshua I
2005-12-06 20:55 ` Frank Ch. Eigler
2005-12-06 16:40 Badari Pulavarty
2005-12-06 16:59 ` Frank Ch. Eigler
2005-12-07  1:10   ` Badari Pulavarty
2005-12-07 15:21     ` William Cohen
2005-12-07 16:37       ` Badari Pulavarty
2005-12-06 17:01 ` Hien Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051207210948.GH9617@redhat.com \
    --to=fche@redhat.com \
    --cc=hunt@redhat.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).