From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15326 invoked by alias); 6 Jan 2006 09:28:36 -0000 Received: (qmail 15320 invoked by uid 22791); 6 Jan 2006 09:28:35 -0000 X-Spam-Status: No, hits=-0.5 required=5.0 tests=AWL,BAYES_20,DNS_FROM_RFC_ABUSE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from e5.ny.us.ibm.com (HELO e5.ny.us.ibm.com) (32.97.182.145) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Jan 2006 09:28:29 +0000 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e5.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id k069SHRR008435 for ; Fri, 6 Jan 2006 04:28:17 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.12.10/NCO/VERS6.8) with ESMTP id k069SHbC131880 for ; Fri, 6 Jan 2006 04:28:17 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11/8.13.3) with ESMTP id k069SGma007846 for ; Fri, 6 Jan 2006 04:28:17 -0500 Received: from newton.in.ibm.com (wks126559wss.in.ibm.com [9.182.15.3] (may be forged)) by d01av02.pok.ibm.com (8.12.11/8.12.11) with ESMTP id k069SGsW007815; Fri, 6 Jan 2006 04:28:16 -0500 Received: by newton.in.ibm.com (Postfix, from userid 500) id A0E67CE3; Fri, 6 Jan 2006 15:01:47 +0530 (IST) Date: Fri, 06 Jan 2006 09:28:00 -0000 From: Prasanna S Panchamukhi To: "Zhang, Yanmin" Cc: systemtap@sources.redhat.com, "Keshavamurthy, Anil S" , "Mao, Bibo" Subject: Re: Review patches of user space kprobe Message-ID: <20060106093147.GG18495@in.ibm.com> Reply-To: prasanna@in.ibm.com References: <8126E4F969BA254AB43EA03C59F44E84046927CA@pdsmsx404> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8126E4F969BA254AB43EA03C59F44E84046927CA@pdsmsx404> User-Agent: Mutt/1.4.1i X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00035.txt.bz2 > >>> are only executed after the loop of hlist_for_each_entry. Is it correct? > >>> > >> > >>that's correct. The page is mapped only once for the first match in the loop, > >>then all the probes are inserted into that page in the hlist_for_each loop and > >>then the page is unmapped only once after the end of the loop. > So call lock_page for many times, and call unlock_page for one time? > no, lock_page and unlock_page is called only once, there is a small correction, insert_probe_page() should be moved out of if condition so that all probes are inserted on that page. Thanks Prasanna -- Prasanna S Panchamukhi Linux Technology Center India Software Labs, IBM Bangalore Email: prasanna@in.ibm.com Ph: 91-80-25044636