public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* returnval()
@ 2006-02-20 22:11 Hien Nguyen
  2006-02-20 22:18 ` returnval() Roland McGrath
  2006-02-21  8:22 ` returnval() Martin Hunt
  0 siblings, 2 replies; 5+ messages in thread
From: Hien Nguyen @ 2006-02-20 22:11 UTC (permalink / raw)
  To: Martin Hunt, SystemTAP

Does anyone know why returnval does not compile on ppc64?

/tmp/stappNLzAB/stap_21443.c: In function `function_returnval':
/tmp/stappNLzAB/stap_21443.c:34540: warning: implicit declaration of 
function `dwarf_register_0'
make[1]: *** [/tmp/stappNLzAB/stap_21443.o] Error 1

Hien.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: returnval()
  2006-02-20 22:11 returnval() Hien Nguyen
@ 2006-02-20 22:18 ` Roland McGrath
  2006-02-21  8:24   ` returnval() Martin Hunt
  2006-02-21  8:22 ` returnval() Martin Hunt
  1 sibling, 1 reply; 5+ messages in thread
From: Roland McGrath @ 2006-02-20 22:18 UTC (permalink / raw)
  To: Hien Nguyen; +Cc: Martin Hunt, SystemTAP

That definition is a kludge.  The elfutils libraries now provide sufficient
information for a proper translator implementation of return value support.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: returnval()
  2006-02-20 22:11 returnval() Hien Nguyen
  2006-02-20 22:18 ` returnval() Roland McGrath
@ 2006-02-21  8:22 ` Martin Hunt
  1 sibling, 0 replies; 5+ messages in thread
From: Martin Hunt @ 2006-02-21  8:22 UTC (permalink / raw)
  To: Hien Nguyen; +Cc: systemtap

On Mon, 2006-02-20 at 14:11 -0800, Hien Nguyen wrote:
> Does anyone know why returnval does not compile on ppc64?

Yeah, that was a mistake. I had a function called returnval() which was
x86 and x86_64 only that I was using. I should probably have been using
retval() instead, but I ended up checking in returnval() too. 

We need to standardize on one. retval() came first, but returnval() is
documented. Maybe they can go away after PR 1132 is fixed, but we need
only one until then. Interest. "man stapprobes" documents a mysterious
"$retvalue" which is apparently not implemented yet.

retval(), $retval
returnval(), $returnval
retvalue(), $retvalue

I'm confused. For now, I updated returnval() to be the same as retval(),
so it should work for ppc64.

Martin






^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: returnval()
  2006-02-20 22:18 ` returnval() Roland McGrath
@ 2006-02-21  8:24   ` Martin Hunt
  2006-02-21 20:44     ` returnval() Roland McGrath
  0 siblings, 1 reply; 5+ messages in thread
From: Martin Hunt @ 2006-02-21  8:24 UTC (permalink / raw)
  To: Roland McGrath; +Cc: Hien Nguyen, systemtap

On Mon, 2006-02-20 at 14:18 -0800, Roland McGrath wrote:
> That definition is a kludge.  The elfutils libraries now provide sufficient
> information for a proper translator implementation of return value support.

If so, some PRs need updated.

See http://sources.redhat.com/bugzilla/show_bug.cgi?id=1132
which points to elfutils PR
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166118
which is still open and assigned to you.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: returnval()
  2006-02-21  8:24   ` returnval() Martin Hunt
@ 2006-02-21 20:44     ` Roland McGrath
  0 siblings, 0 replies; 5+ messages in thread
From: Roland McGrath @ 2006-02-21 20:44 UTC (permalink / raw)
  To: Martin Hunt; +Cc: Hien Nguyen, systemtap

> If so, some PRs need updated.

Indeed.  I updated those.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-02-21 20:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-20 22:11 returnval() Hien Nguyen
2006-02-20 22:18 ` returnval() Roland McGrath
2006-02-21  8:24   ` returnval() Martin Hunt
2006-02-21 20:44     ` returnval() Roland McGrath
2006-02-21  8:22 ` returnval() Martin Hunt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).