From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10643 invoked by alias); 2 Mar 2006 09:43:38 -0000 Received: (qmail 10539 invoked by uid 48); 2 Mar 2006 09:43:03 -0000 Date: Thu, 02 Mar 2006 09:43:00 -0000 Message-ID: <20060302094303.10538.qmail@sourceware.org> From: "bibo dot mao at intel dot com" To: systemtap@sources.redhat.com In-Reply-To: <20060301202710.2408.anil.s.keshavamurthy@intel.com> References: <20060301202710.2408.anil.s.keshavamurthy@intel.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug kprobes/2408] [RHEL4 U4] Backport Kprobes fixes from mainline X-Bugzilla-Reason: AssignedTo Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00683.txt.bz2 ------- Additional Comments From bibo dot mao at intel dot com 2006-03-02 09:43 ------- I test the patch in IA32 and IA64 platfrom about RHEL4-U3-RC3 2.6.9-34 kernel version, and in IA32 there is one patch need modification in nx.patch +void __kprobes arch_remove_kprobe(struct kprobe *p) should be +void arch_remove_kprobe(struct kprobe *p), __kprobes is not defined in RHEL4 series. And in IA64 platform, http://sourceware.org/bugzilla/show_bug.cgi?id=2071 still unsolved. And I will test in x86_64 platform. And as anath pointed out, in iA64 platform it also should be checked. if (args->regs && user_mode(args->regs)) return ret; Now I am sure for IA32, x86_64, for safety I suggest it should be check in all platform. -- http://sourceware.org/bugzilla/show_bug.cgi?id=2408 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.