public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "joshua dot i dot stone at intel dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug translator/2475] New: Inlines don't match filenames correctly
Date: Wed, 22 Mar 2006 00:55:00 -0000	[thread overview]
Message-ID: <20060322005515.2475.joshua.i.stone@intel.com> (raw)

Consider a probe like this:
    probe kernel.inline("*@include/linux/mm.h")

The expected behavior is that this would probe all instances of inlines defined
within "include/linux/mm.h".  However, on i686 2.6.9-34.ELsmp, this actually
matches the following set:

  static struct kprobe dwarf_kprobe_4[17688]= {
    {.addr= (void *) 0xc0100566},
    {.addr= (void *) 0xc01005ac},
    {.addr= (void *) 0xc01005e1},
    {.addr= (void *) 0xc01005e6},
    {.addr= (void *) 0xc01005fc},
    ...
  };
 
  char const * dwarf_kprobe_0_location_names[17688] = {
    "kernel.inline(\"unlock_kernel@include/linux/smp_lock.h:53\")",
    "kernel.inline(\"execve@include/asm/unistd.h:437\")",
    "kernel.inline(\"get_current@include/asm/current.h:9\")",
    "kernel.inline(\"get_current@include/asm/current.h:9\")",
    "kernel.inline(\"fixup_cpu_present_map@init/main.c:761\")",
    ...
  };

At first glance I thought that this was all instances of inlines *used* within
the given file.  However, it seems suspicious that execve would be called from
within mm.h.  Closer inspection of the matching address (0xc01005ac) shows that
this probe point is the execve call within "run_init_process" in "init/main.c".
 In fact, all of the addresses from the exerpt above are from "init/main.c", and
have no obvious tie to "include/linux/mm.h".

So it appears that filename matching for inlines is completely broken...

See also this thread:
http://sources.redhat.com/ml/systemtap/2006-q1/msg00817.html

-- 
           Summary: Inlines don't match filenames correctly
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: joshua dot i dot stone at intel dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=2475

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

                 reply	other threads:[~2006-03-22  0:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060322005515.2475.joshua.i.stone@intel.com \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).