public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "jkenisto at us dot ibm dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug kprobes/2476] New: Switch Kprobes inline functions to __kprobes?
Date: Thu, 23 Mar 2006 00:45:00 -0000	[thread overview]
Message-ID: <20060323004500.2476.jkenisto@us.ibm.com> (raw)

In LKML on 3/20/2006, Andrew Morton said:
> +static inline int uprobe_fault_handler(struct pt_regs *regs, int trapnr)

If, for some reason, the compiler decides to not inline this function then
you have a hunk of code which isn't marked __kprobes, but it should be.

I'd suggest that you remove all inlining from this code and add the
appropriate section markers.

Or I guess you could use __always_inline, but I'm not sure that it's really
worth the fuss and obscurity of doing that.

All kprobes-related code should be audited for this problem.

-- 
           Summary: Switch Kprobes inline functions to __kprobes?
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: kprobes
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: jkenisto at us dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=2476

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

             reply	other threads:[~2006-03-23  0:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-23  0:45 jkenisto at us dot ibm dot com [this message]
2006-03-23  4:56 ` [Bug kprobes/2476] " prasanna at in dot ibm dot com
2006-03-25  9:51 ` prasanna at in dot ibm dot com
2006-04-07 14:12 ` prasanna at in dot ibm dot com
2006-04-07 14:14 ` prasanna at in dot ibm dot com
2006-04-08  7:43 ` prasanna at in dot ibm dot com
2006-04-10  3:24 ` bibo dot mao at intel dot com
2006-04-10  4:30   ` Prasanna S Panchamukhi
2006-04-10  4:30 ` prasanna at in dot ibm dot com
2006-04-13 16:16 ` prasanna at in dot ibm dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060323004500.2476.jkenisto@us.ibm.com \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).