From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 684 invoked by alias); 31 Mar 2006 17:49:12 -0000 Received: (qmail 671 invoked by uid 48); 31 Mar 2006 17:49:09 -0000 Date: Fri, 31 Mar 2006 17:49:00 -0000 Message-ID: <20060331174909.670.qmail@sourceware.org> From: "hunt at redhat dot com" To: systemtap@sources.redhat.com In-Reply-To: <20060330093952.2497.guanglei@cn.ibm.com> References: <20060330093952.2497.guanglei@cn.ibm.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug runtime/2497] STP_STRING_SIZE set by stap is too small X-Bugzilla-Reason: AssignedTo Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00913.txt.bz2 ------- Additional Comments From hunt at redhat dot com 2006-03-31 17:49 ------- If you use backtrace(), it puts it's results in a string, so MAXSTRINGLEN must be adjusted. If you use print_backtrace() it writes the output directly to stdout so there is no limit. EXCEPT I see the ppc64 __stp_stack_sprint() function has put an incorrect limit there. Perhaps that is the real problem you are trying to fix? If you want to fix that function, consider that if "str == _stp_stdout" then the output is going to the output buffer, not a string of size STP_STRING_SIZE. Also it looks like this backtrace function loops until it has filled up the output buffer, not finished the backtrace, which is a very bad idea, especially because it is not clear to me this won't loop forever in some cases. -- http://sourceware.org/bugzilla/show_bug.cgi?id=2497 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.