From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15850 invoked by alias); 4 Apr 2006 02:08:27 -0000 Received: (qmail 15825 invoked by uid 48); 4 Apr 2006 02:08:19 -0000 Date: Tue, 04 Apr 2006 02:08:00 -0000 Message-ID: <20060404020819.15824.qmail@sourceware.org> From: "guij at cn dot ibm dot com" To: systemtap@sources.redhat.com In-Reply-To: <20060330093952.2497.guanglei@cn.ibm.com> References: <20060330093952.2497.guanglei@cn.ibm.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug runtime/2497] STP_STRING_SIZE set by stap is too small X-Bugzilla-Reason: AssignedTo Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q2/txt/msg00026.txt.bz2 ------- Additional Comments From guij at cn dot ibm dot com 2006-04-04 02:08 ------- (In reply to comment #9) > But aren't there just two possibilities? > 1. You print the backtrace. > 2. You get the backtrace in a string and save it in an array. > > For #1, you use print_backtrace. For #2, you need to have all strings be > larger, as it is done now. > > In your example above, you would just write something like this in > script: > > bin_write("%1b%4b%1b%ld%4b%4b", cmd->device->sdev_state, [...]) > print_backtrace() > I think _lket_trace() is more like: bin_write("%n%1b%4b%1b%ld%4b%4b%s",this_event_len(), cmd->device->sdev_state, [...], _stp_string_ptr(str)) The total length of the trace record (including backtrace string) is to be calculated and filled by bin_write(), thus only #2 can work. -- http://sourceware.org/bugzilla/show_bug.cgi?id=2497 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.