public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@redhat.com>
To: Guang Lei Li <liguangl@cn.ibm.com>
Cc: systemtap@sources.redhat.com
Subject: Re: adding statements in alias definition as epilogue
Date: Wed, 05 Apr 2006 01:24:00 -0000	[thread overview]
Message-ID: <20060405012447.GC16498@redhat.com> (raw)
In-Reply-To: <OFED2AD552.532AEA7F-ON48257147.00020483-48257147.0003CD4B@cn.ibm.com>

Hi -

> > You can have two alias definitions: [...]
> But this won't work either.  [...]

Indeed not, you're right.  OK, how about forking it into independent twins?

probe addevent.tskdispatch.cpuidle = kernel.inline("idle_balance") {
 log_cpuidle_tracedata(HOOKID_TASK_CPUIDLE, 0)
}
probe addevent.tskdispatch.cpuidle.backtrace = kernel.inline("idle_balance") {
 log_cpuidle_tracedata(HOOKID_TASK_CPUIDLE, 1)
}


This assumes that per-probe backtrace configuration makes more sense
than, say, a single global variable.


> [...]  So do we need the option to specify whether to put the
> statements in an alias definition as prologue or epilogue?  [...]  I
> am not sure if other people than me have this requirement too. [...]

It still seems like a big step to introduce this inverted data/control
flow.  We would have to consider composing multiple levels of aliases,
to make sure a programmer and a user can reason easily about what
should happen.

- FChE

  reply	other threads:[~2006-04-05  1:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-05  0:41 Guang Lei Li
2006-04-05  1:24 ` Frank Ch. Eigler [this message]
2006-04-05  2:46   ` Guang Lei Li
2006-04-05 12:03     ` Frank Ch. Eigler
2006-04-05 16:06       ` Guang Lei Li
2006-04-05 20:16         ` Frank Ch. Eigler
  -- strict thread matches above, loose matches on Subject: below --
2006-04-03  9:25 Li Guanglei
2006-04-03  9:59 ` bibo,mao
2006-04-03 16:00 ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060405012447.GC16498@redhat.com \
    --to=fche@redhat.com \
    --cc=liguangl@cn.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).