From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27504 invoked by alias); 5 Apr 2006 01:24:52 -0000 Received: (qmail 27497 invoked by uid 22791); 5 Apr 2006 01:24:51 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Apr 2006 01:24:50 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k351OmrU015945; Tue, 4 Apr 2006 21:24:48 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k351OmSJ012532; Tue, 4 Apr 2006 21:24:48 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id k351OmlO009509; Tue, 4 Apr 2006 21:24:48 -0400 Received: from ton.toronto.redhat.com (ton.toronto.redhat.com [172.16.14.15]) by touchme.toronto.redhat.com (Postfix) with ESMTP id D831A8002B7; Tue, 4 Apr 2006 21:24:47 -0400 (EDT) Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id k351OlIk021841; Tue, 4 Apr 2006 21:24:47 -0400 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id k351Ol8s021840; Tue, 4 Apr 2006 21:24:47 -0400 Date: Wed, 05 Apr 2006 01:24:00 -0000 From: "Frank Ch. Eigler" To: Guang Lei Li Cc: systemtap@sources.redhat.com Subject: Re: adding statements in alias definition as epilogue Message-ID: <20060405012447.GC16498@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q2/txt/msg00035.txt.bz2 Hi - > > You can have two alias definitions: [...] > But this won't work either. [...] Indeed not, you're right. OK, how about forking it into independent twins? probe addevent.tskdispatch.cpuidle = kernel.inline("idle_balance") { log_cpuidle_tracedata(HOOKID_TASK_CPUIDLE, 0) } probe addevent.tskdispatch.cpuidle.backtrace = kernel.inline("idle_balance") { log_cpuidle_tracedata(HOOKID_TASK_CPUIDLE, 1) } This assumes that per-probe backtrace configuration makes more sense than, say, a single global variable. > [...] So do we need the option to specify whether to put the > statements in an alias definition as prologue or epilogue? [...] I > am not sure if other people than me have this requirement too. [...] It still seems like a big step to introduce this inverted data/control flow. We would have to consider composing multiple levels of aliases, to make sure a programmer and a user can reason easily about what should happen. - FChE