public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Prasanna S Panchamukhi <prasanna@in.ibm.com>
Cc: linux-kernel@vger.kernel.org, systemtap@sources.redhat.com,
		akpm@osdl.org, Andi Kleen <ak@suse.de>,
	davem@davemloft.net, 	suparna@in.ibm.com,
	richardj_moore@uk.ibm.com
Subject: Re: [RFC] [PATCH 2/6] Kprobes: Get one pagetable entry
Date: Tue, 09 May 2006 09:34:00 -0000	[thread overview]
Message-ID: <20060509093441.GA26953@infradead.org> (raw)
In-Reply-To: <20060509070106.GB22493@in.ibm.com>

On Tue, May 09, 2006 at 12:31:06PM +0530, Prasanna S Panchamukhi wrote:
> This patch provide a wrapper routine to allocate one page
> table entry for a given virtual address address. Kprobe's
> user-space probe mechanism uses this routine to get one
> page table entry. As Nick Piggin suggested, this generic
> routine can be used by routines like get_user_pages,
> find_*_page, and other standard APIs.

In find_*_page it defintily cannot be used because theses routines
are doing pagecache lookups and couldn't care less about users.

If you want to get this patch in convert the places currently opencoding
to it, otherwise it just adds more bloat.

      parent reply	other threads:[~2006-05-09  9:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-09  6:55 [RFC] [PATCH 0/6] Kprobes: User-space probes support for i386 Prasanna S Panchamukhi
2006-05-09  6:59 ` [RFC] [PATCH 1/6] Kprobes: Allow/deny exclusive write access to inodes Prasanna S Panchamukhi
2006-05-09  7:01   ` [RFC] [PATCH 2/6] Kprobes: Get one pagetable entry Prasanna S Panchamukhi
2006-05-09  7:05     ` [RFC] [PATCH 3/6] Kprobes: New interfaces for user-space probes Prasanna S Panchamukhi
2006-05-09  7:09       ` [RFC] [PATCH 4/6] Kprobes: Insert probes on non-memory resident pages Prasanna S Panchamukhi
2006-05-09  7:12         ` [RFC] [PATCH 5/6] Kprobes: Single step the original instruction out-of-line Prasanna S Panchamukhi
2006-05-09  7:15           ` [RFC] [PATCH 6/6] Kprobes: Remove breakpoints from the copied pages Prasanna S Panchamukhi
2006-05-09 17:04             ` Hugh Dickins
2006-05-09 18:12               ` Frank Ch. Eigler
2006-05-10  8:42                 ` Prasanna S Panchamukhi
2006-05-10 12:18               ` Prasanna S Panchamukhi
2006-05-10 19:16                 ` Hugh Dickins
2006-05-09  9:38           ` [RFC] [PATCH 5/6] Kprobes: Single step the original instruction out-of-line Christoph Hellwig
2006-05-10  0:47           ` bibo,mao
2006-05-10 14:20             ` Richard J Moore
2006-05-09  9:34     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060509093441.GA26953@infradead.org \
    --to=hch@infradead.org \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prasanna@in.ibm.com \
    --cc=richardj_moore@uk.ibm.com \
    --cc=suparna@in.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).