From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6832 invoked by alias); 9 May 2006 09:34:55 -0000 Received: (qmail 6823 invoked by uid 22791); 9 May 2006 09:34:54 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from pentafluge.infradead.org (HELO pentafluge.infradead.org) (213.146.154.40) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 May 2006 09:34:50 +0000 Received: from hch by pentafluge.infradead.org with local (Exim 4.62 #1 (Red Hat Linux)) id 1FdOc5-00071Y-Se; Tue, 09 May 2006 10:34:41 +0100 Date: Tue, 09 May 2006 09:34:00 -0000 From: Christoph Hellwig To: Prasanna S Panchamukhi Cc: linux-kernel@vger.kernel.org, systemtap@sources.redhat.com, akpm@osdl.org, Andi Kleen , davem@davemloft.net, suparna@in.ibm.com, richardj_moore@uk.ibm.com Subject: Re: [RFC] [PATCH 2/6] Kprobes: Get one pagetable entry Message-ID: <20060509093441.GA26953@infradead.org> Mail-Followup-To: Christoph Hellwig , Prasanna S Panchamukhi , linux-kernel@vger.kernel.org, systemtap@sources.redhat.com, akpm@osdl.org, Andi Kleen , davem@davemloft.net, suparna@in.ibm.com, richardj_moore@uk.ibm.com References: <20060509065455.GA11630@in.ibm.com> <20060509065917.GA22493@in.ibm.com> <20060509070106.GB22493@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060509070106.GB22493@in.ibm.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q2/txt/msg00353.txt.bz2 On Tue, May 09, 2006 at 12:31:06PM +0530, Prasanna S Panchamukhi wrote: > This patch provide a wrapper routine to allocate one page > table entry for a given virtual address address. Kprobe's > user-space probe mechanism uses this routine to get one > page table entry. As Nick Piggin suggested, this generic > routine can be used by routines like get_user_pages, > find_*_page, and other standard APIs. In find_*_page it defintily cannot be used because theses routines are doing pagecache lookups and couldn't care less about users. If you want to get this patch in convert the places currently opencoding to it, otherwise it just adds more bloat.