From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7774 invoked by alias); 9 May 2006 09:38:33 -0000 Received: (qmail 7765 invoked by uid 22791); 9 May 2006 09:38:33 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from pentafluge.infradead.org (HELO pentafluge.infradead.org) (213.146.154.40) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 May 2006 09:38:32 +0000 Received: from hch by pentafluge.infradead.org with local (Exim 4.62 #1 (Red Hat Linux)) id 1FdOfj-00076q-5Y; Tue, 09 May 2006 10:38:27 +0100 Date: Tue, 09 May 2006 09:38:00 -0000 From: Christoph Hellwig To: Prasanna S Panchamukhi Cc: linux-kernel@vger.kernel.org, systemtap@sources.redhat.com, akpm@osdl.org, Andi Kleen , davem@davemloft.net, suparna@in.ibm.com, richardj_moore@uk.ibm.com Subject: Re: [RFC] [PATCH 5/6] Kprobes: Single step the original instruction out-of-line Message-ID: <20060509093827.GD26953@infradead.org> Mail-Followup-To: Christoph Hellwig , Prasanna S Panchamukhi , linux-kernel@vger.kernel.org, systemtap@sources.redhat.com, akpm@osdl.org, Andi Kleen , davem@davemloft.net, suparna@in.ibm.com, richardj_moore@uk.ibm.com References: <20060509065455.GA11630@in.ibm.com> <20060509065917.GA22493@in.ibm.com> <20060509070106.GB22493@in.ibm.com> <20060509070508.GC22493@in.ibm.com> <20060509070911.GD22493@in.ibm.com> <20060509071204.GE22493@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060509071204.GE22493@in.ibm.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q2/txt/msg00354.txt.bz2 On Tue, May 09, 2006 at 12:42:04PM +0530, Prasanna S Panchamukhi wrote: > Even if the vma cannot be extended, then the instruction much be > executed inline, by replacing the breakpoint instruction with the > original instruction. Patching pagecache content is not acceptable. Just fail the probe in this case.