public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: systemtap@sources.redhat.com
Subject: Re: kprobes trampoline_p registration
Date: Mon, 12 Jun 2006 13:42:00 -0000	[thread overview]
Message-ID: <20060612134216.GA21393@in.ibm.com> (raw)
In-Reply-To: <20060612093007.GA29431@localhost.localdomain>

On Mon, Jun 12, 2006 at 05:30:07AM -0400, Mike Grundy wrote:
> Hi - I noticed in 2.6.17-rc6 in the i386 kprobes.c the registration of the
> trampoline probe in arch_init_kprobes was removed. It looks like that pile of
> assembly in kretprobe_trampoline_holder does the clean up instead of using the
> regular mechanisms. Any particular reason for this? Should the other arches
> consider a similar mechanism?

Mike,

That is the result of Masami's kprobe booster patchset and is applicable
to i386 (there is a patch floating around for ia64 too).

Other archs that don't have a booster implementation (powerpc for
instance) still use the older trampoline probe mechanism for function
return probes. Until such time the other archs have the booster
implemented, they'll need the trampoline probe registered as part of
arch_init_kprobes().

Ananth

  reply	other threads:[~2006-06-12 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-12 13:29 Mike Grundy
2006-06-12 13:42 ` Ananth N Mavinakayanahalli [this message]
2006-06-13  7:38 ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060612134216.GA21393@in.ibm.com \
    --to=ananth@in.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).