From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Jan Glauber <jan.glauber@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org,
systemtap@sources.redhat.com
Subject: Re: [PATCH] kprobes for s390 architecture
Date: Mon, 26 Jun 2006 10:33:00 -0000 [thread overview]
Message-ID: <20060626080910.GA9418@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20060625133128.GA23432@localhost.localdomain>
> Here's what I came up with Friday before I jumped timezones back east:
>
> void smp_replace_instruction(void *info)
> {
> struct ins_replace_args *parms;
>
> parms = (struct ins_replace_args *) info;
> cmpxchg(parms->addr, parms->oinsn, parms->ninsn);
> }
>
> void __kprobes arch_arm_kprobe(struct kprobe *p)
> {
> struct ins_replace_args parms;
> parms.addr = p->addr;
> parms.ninsn = BREAKPOINT_INSTRUCTION;
> parms.oinsn = p->opcode;
>
> on_each_cpu(smp_replace_instruction, &parms, 0, 1);
> } etc...
>
> After reading your notes it's probably overkill doing the cs on each cpu, since
> the interrupt will discard the prefetched instructions.
Indeed. Another thing that should not be forgotten: it could be that the
whole kernel text segment resides in a shared read only segment. So it can
be shared by multiple z/VM guests.
In that case the cs instruction will fail. Looks like you need to write the
part that replaces the instruction in assembly and supply a fixup section
which in turn makes sure that -EFAULT is returned.
next prev parent reply other threads:[~2006-06-26 8:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060623150344.GL9446@osiris.boeblingen.de.ibm.com>
2006-06-23 16:04 ` [heiko.carstens@de.ibm.com: Re: [PATCH] kprobes for s390 architecture] Michael Grundy
2006-06-23 22:21 ` [PATCH] kprobes for s390 architecture Heiko Carstens
2006-06-24 12:16 ` Heiko Carstens
2006-06-24 14:27 ` Heiko Carstens
2006-06-26 8:10 ` Mike Grundy
2006-06-26 10:33 ` Heiko Carstens [this message]
2006-06-27 18:53 ` Martin Schwidefsky
2006-06-28 16:49 ` Heiko Carstens
2006-07-07 17:23 ` Mike Grundy
2006-07-07 17:27 ` Heiko Carstens
2006-07-07 19:51 ` Frank Ch. Eigler
2006-07-08 15:59 ` Mike Grundy
2006-07-08 18:54 ` Mike Grundy
2006-07-08 19:58 ` Mike Grundy
2006-07-10 9:31 ` Heiko Carstens
2006-07-10 22:20 ` Mike Grundy
2006-07-10 14:25 ` Frank Ch. Eigler
2006-07-10 15:51 ` Frank Ch. Eigler
2006-07-11 13:54 ` Mike Grundy
2006-07-11 14:13 ` Martin Schwidefsky
2006-06-24 11:37 ` [heiko.carstens@de.ibm.com: Re: [PATCH] kprobes for s390 architecture] Michael Grundy
2006-06-12 17:17 [PATCH] kprobes for s390 architecture Mike Grundy
2006-06-12 19:40 ` Martin Schwidefsky
2006-06-21 4:28 ` Mike Grundy
2006-06-21 16:38 ` Martin Schwidefsky
2006-06-21 17:15 ` Mike Grundy
2006-06-27 11:58 ` Martin Schwidefsky
2006-06-21 17:34 ` Mike Grundy
2006-06-22 11:28 ` Jan Glauber
2006-06-22 16:36 ` Mike Grundy
2006-06-23 8:50 ` Jan Glauber
2006-06-23 14:39 ` Heiko Carstens
2006-06-22 1:38 ` Mike Grundy
2006-06-21 9:40 ` Jan Glauber
2006-06-21 16:23 ` Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060626080910.GA9418@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=jan.glauber@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).