From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10679 invoked by alias); 27 Jun 2006 23:40:01 -0000 Received: (qmail 10671 invoked by uid 22791); 27 Jun 2006 23:40:00 -0000 X-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_FAIL X-Spam-Check-By: sourceware.org Received: from gateway.sf.frob.com (HELO gateway.sf.frob.com) (64.81.54.130) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Jun 2006 23:39:59 +0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id E79AE357B; Tue, 27 Jun 2006 16:39:55 -0700 (PDT) Received: by magilla.sf.frob.com (Postfix, from userid 5281) id 9938918004B; Tue, 27 Jun 2006 16:39:55 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: David Smith Cc: "Stone, Joshua I" , "Frank Ch. Eigler" , Systemtap List Subject: RE: pre-compiled modules In-Reply-To: David Smith's message of Tuesday, 27 June 2006 14:59:28 -0500 <1151438368.24128.31.camel@dhcp-2.hsv.redhat.com> X-Windows: a mistake carried out to perfection. Message-Id: <20060627233955.9938918004B@magilla.sf.frob.com> Date: Wed, 28 Jun 2006 00:49:00 -0000 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q2/txt/msg00706.txt.bz2 > > > To help move this along a bit, I've attached a patch that modifies the > > > systemtap front end to take 2 new options: > > > > > > -S Save the compiled module in the current directory > > > > I would prefer to see an option to specify the directory, instead of > > assuming $PWD. You could always use '-S .', but some people might want > > to drop it somewhere else. Another possibility instead of -S is to just > > extend the -m option to allow a path. > > That's easy enough to add, but it seems like that 99% of the time I'd > want it to go in the current directory. > > Anyone else got any opinions? The output compiled module is the single .ko file, right? That being the case, I think what makes the most sense is an option that takes a file name. > > Have you thought about concurrent access to a precompiled module? If > > you have a systemtap module foo.ko on a multi-user system, you might end > > up with a situation where multiple people want to run it at the same > > time. Of course you can only insmod one at a time, if nothing else > > because of the naming issue. > > Hmm, no I hadn't considered that. We've also got a similar but > different problem. What happens when 2 users both compile two different > scripts called 'foo.stp' into 'foo.ko', then try to run them > concurrently? It doesn't matter what the name of the .ko file is at load time. The module name is embedded in the struct module that's compiled into the file by the Kbuild process. So as to the latter case of unrelated modules that users think of as having the same name, that is easily avoided by choosing unique names at module compilation time.