public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "hunt at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug tapsets/2861] New: user_string fault handling
Date: Wed, 28 Jun 2006 18:56:00 -0000	[thread overview]
Message-ID: <20060628164947.2861.hunt@redhat.com> (raw)

Fallout from bug 2637.  Now that we have more page faults, we must handle them
gracefully.

Currently when user_string() fails, it sets CONTEXT->last_error, which causes
the script to exit, unless you set MAXERRORS to something high enough. Using
MAXERRORS this way is not appropriate and you end up just always setting it to
something high so your scripts don't terminate, even if they should because they
are dividing by zero or overflowing arrays. Userspace data not always being
available is an expected limitation of our implementation, not an unexpected error.

I think a better solution is to generate a warning and return "<unknown>".
The warning might even be optional. 

This has been discussed before with no consensus.  Leaving things broken is not
an option. Please document your objections and post alternatives.

-- 
           Summary: user_string fault handling
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P1
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: hunt at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=2861

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

             reply	other threads:[~2006-06-28 16:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 18:56 hunt at redhat dot com [this message]
2006-06-28 20:43 ` [Bug tapsets/2861] " fche at redhat dot com
2006-06-28 20:49 ` varap at us dot ibm dot com
2006-06-28 20:54 ` hien at us dot ibm dot com
2006-06-29  1:08 ` hunt at redhat dot com
2006-06-29  2:12 ` fche at redhat dot com
2006-06-29  3:16   ` James Dickens
2006-06-30 19:13   ` Martin Hunt
2006-06-29  9:31 ` jamesd dot wi at gmail dot com
2006-06-30 20:10 ` hunt at redhat dot com
2006-07-11 21:17 ` hunt at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060628164947.2861.hunt@redhat.com \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).