From: "guanglei at cn dot ibm dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug translator/2422] module("*") probes fail with debug-info-less modules
Date: Mon, 31 Jul 2006 14:32:00 -0000 [thread overview]
Message-ID: <20060731143249.27100.qmail@sourceware.org> (raw)
In-Reply-To: <20060306154835.2422.wcohen@redhat.com>
------- Additional Comments From guanglei at cn dot ibm dot com 2006-07-31 14:32 -------
(In reply to comment #3)
> What happens if we just switch to get_module_dwarf(false) altogether? (Testing
> for equality with "*" would be insufficient - we have wildcards like "*foo*".)
Simply calling get_module_dwarf(false) seems enough. Here is a patch:
RCS file: /cvs/systemtap/src/tapsets.cxx,v
retrieving revision 1.137
diff -r1.137 tapsets.cxx
558c558
< void get_module_dwarf(bool required = true)
---
> void get_module_dwarf(bool required = false)
585c585
< get_module_dwarf(true);
---
> get_module_dwarf(false);
This patch will:
if MPATTERN contains wildcard(*,?,[])
{
foreach module in MPATTERN
{
if this module has no debuginfo
give a warning and continue
}
if all modules have no debuginfo
&& this probe point is not optional
{
give an error and stop
} else
give a warning and continue
} else {
if this module has no debuginfo
&& this probe point is not optional
give an error and stop
else
give a warning and continue
}
I tried different combinations and it passed tests:
probe module("*ath*").function("*dispatch*"), kernel.function("sys_getsid")
probe module("*ath*").function("*dispatch*") ?, kernel.function("sys_getsid")
probe module("ath_[abcp]ci").function("*dispatch*"), kernel.function("sys_getsid")
probe module("ath_[abcp]ci").function("*dispatch*")?, kernel.function("sys_getsid")
probe module("ath_[abcp]ci").statement("0xf89aae29")
probe module("ath_[abcp]ci").statement("0xf89aae29")?
...
--
http://sourceware.org/bugzilla/show_bug.cgi?id=2422
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
next prev parent reply other threads:[~2006-07-31 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 15:48 [Bug translator/2422] New: running multiple systemtap instrumentation when module("*") is used wcohen at redhat dot com
2006-03-06 16:44 ` [Bug translator/2422] module("*") probes fail with debug-info-less modules fche at redhat dot com
2006-07-24 3:37 ` guanglei at cn dot ibm dot com
2006-07-24 20:14 ` fche at redhat dot com
2006-07-31 14:32 ` guanglei at cn dot ibm dot com [this message]
2006-07-31 14:56 ` fche at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731143249.27100.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).