From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26276 invoked by alias); 22 Sep 2006 02:49:05 -0000 Received: (qmail 26268 invoked by uid 22791); 22 Sep 2006 02:49:05 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from tomts10.bellnexxia.net (HELO tomts10-srv.bellnexxia.net) (209.226.175.54) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 22 Sep 2006 02:49:02 +0000 Received: from krystal.dyndns.org ([67.68.212.231]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060922024900.WRUF13241.tomts10-srv.bellnexxia.net@krystal.dyndns.org> for ; Thu, 21 Sep 2006 22:49:00 -0400 Received: from localhost (localhost [127.0.0.1]) (uid 1000) by krystal.dyndns.org with local; Thu, 21 Sep 2006 22:38:28 -0400 id 001C2508.45134CA4.000034B0 Date: Fri, 22 Sep 2006 02:49:00 -0000 From: Mathieu Desnoyers To: Jeremy Fitzhardinge Cc: Martin Bligh , "Frank Ch. Eigler" , Masami Hiramatsu , prasanna@in.ibm.com, Andrew Morton , Ingo Molnar , Paul Mundt , linux-kernel , Jes Sorensen , Tom Zanussi , Richard J Moore , Michel Dagenais , Christoph Hellwig , Greg Kroah-Hartman , Thomas Gleixner , William Cohen , ltt-dev@shafik.org, systemtap@sources.redhat.com, Alan Cox Subject: Re: [PATCH] Linux Kernel Markers 0.7 for 2.6.17 (with type checking!) Message-ID: <20060922023828.GA10291@Krystal> References: <20060921232024.GA16155@Krystal> <451331A1.3020601@goop.org> <20060922020119.GA28712@Krystal> <45134539.7070305@goop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <45134539.7070305@goop.org> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.4.32-grsec (i686) X-Uptime: 22:33:37 up 29 days, 23:42, 2 users, load average: 0.13, 0.23, 0.18 User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q3/txt/msg00694.txt.bz2 * Jeremy Fitzhardinge (jeremy@goop.org) wrote: > Mathieu Desnoyers wrote: > >#define MARK_SYM(name) \ > > do { \ > > __label__ here; \ > > volatile static void *__mark_kprobe_##name \ > > asm (MARK_CALL_PREFIX#name) \ > > __attribute__((unused)) =3D &&here; \ > >here: \ > > do { } while(0); \ > > } while(0) > > > >Which fixes the problem. Some tests showed me that the compiler does not= =20 > >unroll > >an otherwise unrolled loop when this specific macro is called. (test don= e=20 > >with > >-funroll-all-loops). >=20 > Eh? I thought you wanted to avoid changing the generated code?=20=20 > Inhibiting loop unrolling could be a pretty large change... >=20 >From what I see in 2.6.17/2.6.18 makefiles, only -OS and -O2 are generally= =20 used by the build system (no -O3) and there is not use of -funroll-loops. I guess it must not be so useful in this context. Mathieu OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj= .gpg Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68=20