From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6851 invoked by alias); 27 Oct 2006 15:34:55 -0000 Received: (qmail 6842 invoked by uid 22791); 27 Oct 2006 15:34:55 -0000 X-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 27 Oct 2006 15:34:47 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k9RFYhrW018472; Fri, 27 Oct 2006 11:34:43 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id k9RFYhdt012758; Fri, 27 Oct 2006 11:34:43 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k9RFYgh5016219; Fri, 27 Oct 2006 11:34:42 -0400 Received: from ton.toronto.redhat.com (ton.toronto.redhat.com [172.16.14.15]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 8771C800002; Fri, 27 Oct 2006 11:34:42 -0400 (EDT) Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id k9RFYg4u024262; Fri, 27 Oct 2006 11:34:42 -0400 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id k9RFYgto024261; Fri, 27 Oct 2006 11:34:42 -0400 Date: Fri, 27 Oct 2006 15:34:00 -0000 From: "Frank Ch. Eigler" To: Mike Mason Cc: systemtap@sources.redhat.com Subject: Re: marking tapset files Message-ID: <20061027153442.GJ4978@redhat.com> References: <20061027132033.GI4978@redhat.com> <45422243.2060007@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45422243.2060007@us.ibm.com> User-Agent: Mutt/1.4.1i Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q4/txt/msg00262.txt.bz2 Hi - On Fri, Oct 27, 2006 at 08:14:11AM -0700, Mike Mason wrote: > I like the idea of adding the comment. Mechanical enforcement would be > even better. Perhaps a keyword at the top of the file that marks it as > part of a specific tapset. [...] That's a possibility. Short of language extensions though, the translator could parse the tapset scripts first, then warn about duplication. Heck, it could even track the visited dev/inode pairs in struct stapfile, and know if the same file has been seen twice. - FChE