From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14390 invoked by alias); 27 Oct 2006 20:45:47 -0000 Received: (qmail 14371 invoked by uid 22791); 27 Oct 2006 20:45:47 -0000 X-Spam-Status: No, hits=0.6 required=5.0 tests=AWL,BAYES_00,NO_DNS_FOR_FROM,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 27 Oct 2006 20:45:44 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by mga09.intel.com with ESMTP; 27 Oct 2006 13:45:38 -0700 Received: from bambi.jf.intel.com ([134.134.19.188]) by orsmga001.jf.intel.com with ESMTP; 27 Oct 2006 13:45:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: i="4.09,366,1157353200"; d="scan'208"; a="151777791:sNHT23071650" Received: from bambi.jf.intel.com (bambi.jf.intel.com [127.0.0.1]) by bambi.jf.intel.com (8.13.7/8.13.7) with ESMTP id k9RKoVZb012294; Fri, 27 Oct 2006 13:50:31 -0700 Received: (from askeshav@localhost) by bambi.jf.intel.com (8.13.7/8.13.7/Submit) id k9RKoSID012292; Fri, 27 Oct 2006 13:50:28 -0700 Date: Fri, 27 Oct 2006 20:45:00 -0000 From: Keshavamurthy@bambi.jf.intel.com, Anil S To: Jun Koi Cc: prasanna@in.ibm.com, jkenisto@us.ibm.com, hien@us.ibm.com, systemtap@sources.redhat.com Subject: Re: [PATCH] kprobes patch Message-ID: <20061027205027.GA10018@bambi.jf.intel.com> Reply-To: Keshavamurthy@bambi.jf.intel.com, Anil S References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q4/txt/msg00266.txt.bz2 On Sat, Oct 28, 2006 at 03:58:18AM +0900, Jun Koi wrote: > Hello, > > I am not sure if this is a right place to send patch for kprobes, but > here it is. This patch moves the reset command of kprobe instance > into the loop. (against 2.6.18) Hi jun, Yes, you have sent it to the right place. thanks. BTW, is is helpful to know what problem did you encounter due to which you had come up with this patch. Or did you catch this bug by just code review? > > > Signed-off-by: Jun Koi > > > --- a/kernel/kprobes.c 2006-09-20 12:42:06.000000000 +0900 > +++ b/kernel/kprobes.c 2006-10-28 03:52:27.000000000 +0900 > @@ -204,8 +204,8 @@ static int __kprobes aggr_pre_handler(st > set_kprobe_instance(kp); > if (kp->pre_handler(kp, regs)) > return 1; > + reset_kprobe_instance(); > } > - reset_kprobe_instance(); > } > return 0; > }