public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "Bill Rugolsky Jr." <brugolsky@telemetry-investments.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: dave_sperry@ieee.org, systemtap@sources.redhat.com,
		linux-rt-users@vger.kernel.org
Subject: Re: RT Patch set, SystemTap, tcp test fails
Date: Mon, 20 Nov 2006 10:09:00 -0000	[thread overview]
Message-ID: <20061120033341.GA20408@ti64.telemetry-investments.com> (raw)
In-Reply-To: <y0mvelb1ciu.fsf@ton.toronto.redhat.com>

On Sun, Nov 19, 2006 at 02:07:05PM -0500, Frank Ch. Eigler wrote:
> According to mingo's patch set, HRTIMER_REL and HRTIMER_ABS were
> simply renamed to HRTIMER_MODE_REL and HRTIMER_MODE_ABS.  Since these
> are enums instead of macros, a little #ifndef/#define hack would not
> work.  Unless the RT patches identify themselves at compile time, it
> may be tricky to generate code that works with both base and patched
> kernel.

The real-time patch replaces the enumeration constants:

 enum hrtimer_mode {
-       HRTIMER_ABS,    /* Time value is absolute */
-       HRTIMER_REL,    /* Time value is relative to now */
+       HRTIMER_MODE_ABS,       /* Time value is absolute */
+       HRTIMER_MODE_REL,       /* Time value is relative to now */
 };

It is possible to achieve backwards compatibility in enumerations by
simply declaring the deprecated names to have the values assigned to
the new names:

enum hrtimer_mode {
	HRTIMER_MODE_ABS,	/* Time value is absolute */
	HRTIMER_ABS = HRTIMER_MODE_ABS,	/* backwards compatibility */
	HRTIMER_MODE_REL,	/* Time value is relative to now */
	HRTIMER_REL = HRTIMER_MODE_REL,	/* backwards compatibility */
};

Regards,

	Bill Rugolsky

      parent reply	other threads:[~2006-11-20  3:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-19 19:07 Dave Sperry
2006-11-19 20:23 ` Frank Ch. Eigler
2006-11-20  3:33   ` David Sperry
2006-11-20 10:09   ` Bill Rugolsky Jr. [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061120033341.GA20408@ti64.telemetry-investments.com \
    --to=brugolsky@telemetry-investments.com \
    --cc=dave_sperry@ieee.org \
    --cc=fche@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).