public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "jkenisto at us dot ibm dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug kprobes/3541] unsafe printk calls in hand-coded kprobe handlers
Date: Wed, 22 Nov 2006 00:43:00 -0000	[thread overview]
Message-ID: <20061122000532.31988.qmail@sourceware.org> (raw)
In-Reply-To: <20061117231901.3541.jkenisto@us.ibm.com>


------- Additional Comments From jkenisto at us dot ibm dot com  2006-11-22 00:05 -------
Since kprobes doesn't allow handlers to re-enter, the likely deadlock scenario
is anybody -> printk -> release_console_sem [locks logbuf_lock] -> up -> ... ->
try_to_wake_up -> activate_task -> handler -> printk [goes for logbuf_lock again].

Re: (2b), spin_trylock_irqsave() (which is what we want) can fail in perfectly
benign scenarios.  If it does, it's a deadlock only if printk_cpu ==
smp_processor_id().  Otherwise, just go for the lock again with spinlock_irq_save().

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3541

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

  reply	other threads:[~2006-11-22  0:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-18 14:27 [Bug kprobes/3541] New: " jkenisto at us dot ibm dot com
2006-11-22  0:43 ` jkenisto at us dot ibm dot com [this message]
2009-04-01 17:36 ` [Bug kprobes/3541] " fche at redhat dot com
2009-10-07 14:59 ` fche at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061122000532.31988.qmail@sourceware.org \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).