public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug translator/3648] New: Translator should warn users executing tapsets with a clear message
@ 2006-12-04 22:07 varap at us dot ibm dot com
  2006-12-04 22:22 ` [Bug translator/3648] " fche at redhat dot com
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: varap at us dot ibm dot com @ 2006-12-04 22:07 UTC (permalink / raw)
  To: systemtap

In systemtap tapsets and enduser scripts are written in the same language hence
it is very easy for an user to execute tapsets directly. Currently translator
doesn't give a clear error message to warn users of such wrong usage. Translator
should give a clear message to the user explaining why this is a illegal
operation and what they should do to correct it.

-- 
           Summary: Translator should warn users executing tapsets with a
                    clear message
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: varap at us dot ibm dot com
                CC: fche at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=3648

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug translator/3648] Translator should warn users executing tapsets with a clear message
  2006-12-04 22:07 [Bug translator/3648] New: Translator should warn users executing tapsets with a clear message varap at us dot ibm dot com
@ 2006-12-04 22:22 ` fche at redhat dot com
  2006-12-05 19:07 ` varap at us dot ibm dot com
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: fche at redhat dot com @ 2006-12-04 22:22 UTC (permalink / raw)
  To: systemtap


------- Additional Comments From fche at redhat dot com  2006-12-04 22:07 -------
Have you checked out this change?

2006-11-19  Frank Ch. Eigler  <fche@elastic.org>

        * main.cxx (main): Signal parse error if a tapset script
        is given as the user script.



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3648

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug translator/3648] Translator should warn users executing tapsets with a clear message
  2006-12-04 22:07 [Bug translator/3648] New: Translator should warn users executing tapsets with a clear message varap at us dot ibm dot com
  2006-12-04 22:22 ` [Bug translator/3648] " fche at redhat dot com
@ 2006-12-05 19:07 ` varap at us dot ibm dot com
  2006-12-06 16:05 ` varap at us dot ibm dot com
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: varap at us dot ibm dot com @ 2006-12-05 19:07 UTC (permalink / raw)
  To: systemtap


------- Additional Comments From varap at us dot ibm dot com  2006-12-05 18:54 -------
*** Bug 3661 has been marked as a duplicate of this bug. ***

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3648

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug translator/3648] Translator should warn users executing tapsets with a clear message
  2006-12-04 22:07 [Bug translator/3648] New: Translator should warn users executing tapsets with a clear message varap at us dot ibm dot com
  2006-12-04 22:22 ` [Bug translator/3648] " fche at redhat dot com
  2006-12-05 19:07 ` varap at us dot ibm dot com
@ 2006-12-06 16:05 ` varap at us dot ibm dot com
  2006-12-06 18:43 ` fche at redhat dot com
  2007-05-08 18:54 ` fche at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: varap at us dot ibm dot com @ 2006-12-06 16:05 UTC (permalink / raw)
  To: systemtap


------- Additional Comments From varap at us dot ibm dot com  2006-12-05 19:07 -------
(In reply to comment #1)
> Have you checked out this change?
> 
> 2006-11-19  Frank Ch. Eigler  <fche@elastic.org>
> 
>         * main.cxx (main): Signal parse error if a tapset script
>         is given as the user script.
> 
> 

I did look at your change it gives bit following better error message than the past
parse error: tapset file '/usr/local/share/systemtap/tapset/tcp.stp' is already
processed as the user script.
Pass 1: parse failed. Try again with more '-v' (verbose) options.

But it is still not at all clear in my opinion to someone who is not initimately
familiar with the project and implementation. I would prefer to see a message
some what like 
"tapset files can not be run directly. Please run a user script that uses the
required tapset."


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3648

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug translator/3648] Translator should warn users executing tapsets with a clear message
  2006-12-04 22:07 [Bug translator/3648] New: Translator should warn users executing tapsets with a clear message varap at us dot ibm dot com
                   ` (2 preceding siblings ...)
  2006-12-06 16:05 ` varap at us dot ibm dot com
@ 2006-12-06 18:43 ` fche at redhat dot com
  2007-05-08 18:54 ` fche at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: fche at redhat dot com @ 2006-12-06 18:43 UTC (permalink / raw)
  To: systemtap


------- Additional Comments From fche at redhat dot com  2006-12-06 17:14 -------
A tweak to the error message was committed.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=3648

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug translator/3648] Translator should warn users executing tapsets with a clear message
  2006-12-04 22:07 [Bug translator/3648] New: Translator should warn users executing tapsets with a clear message varap at us dot ibm dot com
                   ` (3 preceding siblings ...)
  2006-12-06 18:43 ` fche at redhat dot com
@ 2007-05-08 18:54 ` fche at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: fche at redhat dot com @ 2007-05-08 18:54 UTC (permalink / raw)
  To: systemtap


------- Additional Comments From fche at redhat dot com  2007-05-08 19:54 -------
improved

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=3648

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2007-05-08 18:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-04 22:07 [Bug translator/3648] New: Translator should warn users executing tapsets with a clear message varap at us dot ibm dot com
2006-12-04 22:22 ` [Bug translator/3648] " fche at redhat dot com
2006-12-05 19:07 ` varap at us dot ibm dot com
2006-12-06 16:05 ` varap at us dot ibm dot com
2006-12-06 18:43 ` fche at redhat dot com
2007-05-08 18:54 ` fche at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).