[Bug tapsets/3867] New: ioblocktest.exp doesn't allow for all values of bi_rw, sometimes fails

[Bug tapsets/3867] New: ioblocktest.exp doesn't allow for all values of bi_rw, sometimes fails

[mmlnx at us dot ibm dot com]

The ioblocktest.exp test checks for values of 0 (READ) or 1 (WRITE) coming from
$bio->bi_rw.  It considers any other value a failure.  This isn't exactly how
bio_rw is used.  bio_rw is a bit map that can take on the following values:

/*
 * bio bi_rw flags
 *
 * bit 0 -- read (not set) or write (set)
 * bit 1 -- rw-ahead when set
 * bit 2 -- barrier
 * bit 3 -- fail fast, don't want low level driver retries
 * bit 4 -- synchronous I/O hint: the block layer will unplug immediately
 */
#define BIO_RW          0
#define BIO_RW_AHEAD    1
#define BIO_RW_BARRIER  2
#define BIO_RW_FAILFAST 3
#define BIO_RW_SYNC     4

Also, the upper 16 bits of bi_rw define the io priority.

This test will randomly pass or fail depending on how bi_rw was set when the
last probe was hit.

I'm filing this as a tapsets bug only because there isn't a tests component.

-- 
           Summary: ioblocktest.exp doesn't allow for all values of bi_rw,
                    sometimes fails
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: mmlnx at us dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=3867

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/3867] ioblocktest.exp doesn't allow for all values of bi_rw, sometimes fails

[mmlnx at us dot ibm dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |mmlnx at us dot ibm dot com
                   |redhat dot com              |
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=3867

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.