From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26543 invoked by alias); 16 Jan 2007 18:06:53 -0000 Received: (qmail 26487 invoked by uid 22791); 16 Jan 2007 18:06:52 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from tomts13.bellnexxia.net (HELO tomts13-srv.bellnexxia.net) (209.226.175.34) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 16 Jan 2007 18:06:45 +0000 Received: from krystal.dyndns.org ([67.68.204.133]) by tomts13-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070116180642.HCGE1773.tomts13-srv.bellnexxia.net@krystal.dyndns.org> for ; Tue, 16 Jan 2007 13:06:42 -0500 Received: from localhost (localhost [127.0.0.1]) (uid 1000) by krystal.dyndns.org with local; Tue, 16 Jan 2007 12:56:24 -0500 id 000C405A.45AD11C8.000026D3 Date: Tue, 16 Jan 2007 18:06:00 -0000 From: Mathieu Desnoyers To: Ingo Molnar Cc: Andrew Morton , Greg Kroah-Hartman , Christoph Hellwig , linux-kernel@vger.kernel.org, ltt-dev@shafik.org, "Martin J. Bligh" , Douglas Niehaus , systemtap@sources.redhat.com, Thomas Gleixner , Richard J Moore Subject: [PATCH 1/2] lockdep missing barrier() Message-ID: <20070116175624.GA16022@Krystal> References: <20061220235216.GA28643@Krystal> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.4.32-grsec (i686) X-Uptime: 12:48:38 up 146 days, 14:55, 6 users, load average: 0.79, 1.14, 1.81 User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00113.txt.bz2 This patch adds a barrier() to lockdep.c lockdep_recursion updates. This variable behaves like the preemption count and should therefore use similar memory barriers. This patch applies on 2.6.20-rc4-git3. Signed-off-by: Mathieu Desnoyers --- a/kernel/lockdep.c +++ b/kernel/lockdep.c @@ -166,12 +166,14 @@ static struct list_head chainhash_table[CHAINHASH_SIZE]; void lockdep_off(void) { current->lockdep_recursion++; + barrier(); } EXPORT_SYMBOL(lockdep_off); void lockdep_on(void) { + barrier(); current->lockdep_recursion--; } -- OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68