From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25236 invoked by alias); 26 Jan 2007 02:54:54 -0000 Received: (qmail 25214 invoked by uid 22791); 26 Jan 2007 02:54:52 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from tomts5.bellnexxia.net (HELO tomts5-srv.bellnexxia.net) (209.226.175.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 26 Jan 2007 02:54:46 +0000 Received: from krystal.dyndns.org ([67.68.204.133]) by tomts5-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070126025443.KLIB5067.tomts5-srv.bellnexxia.net@krystal.dyndns.org> for ; Thu, 25 Jan 2007 21:54:43 -0500 Received: from localhost (localhost [127.0.0.1]) (uid 1000) by krystal.dyndns.org with local; Thu, 25 Jan 2007 21:54:41 -0500 id 001E67FB.45B96D71.00000542 Date: Fri, 26 Jan 2007 02:54:00 -0000 From: Mathieu Desnoyers To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Andrew Morton , Ingo Molnar , Greg Kroah-Hartman , Christoph Hellwig , ltt-dev@shafik.org, systemtap@sources.redhat.com, Douglas Niehaus , "Martin J. Bligh" , Thomas Gleixner , Paul Mackerras Subject: Re: [PATCH 02/09] atomic.h : Complete atomic_long operations in asm-generic Message-ID: <20070126025441.GA13004@Krystal> References: <11697417541743-git-send-email-mathieu.desnoyers@polymtl.ca> <1169741754354-git-send-email-mathieu.desnoyers@polymtl.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <1169741754354-git-send-email-mathieu.desnoyers@polymtl.ca> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.4.32-grsec (i686) X-Uptime: 21:52:32 up 155 days, 23:59, 4 users, load average: 0.31, 0.37, 0.40 User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00230.txt.bz2 As Joe Perches pointed out, 4 casts to (long) are unneeded here. The *_test functions only return integers, never a long. Signed-off-by: Mathieu Desnoyers --- a/include/asm-generic/atomic.h +++ b/include/asm-generic/atomic.h @@ -70,28 +70,28 @@ static inline int atomic_long_sub_and_test(long i, atomic_long_t *l) { atomic64_t *v = (atomic64_t *)l; - return (long)atomic64_sub_and_test(i, v); + return atomic64_sub_and_test(i, v); } static inline int atomic_long_dec_and_test(atomic_long_t *l) { atomic64_t *v = (atomic64_t *)l; - return (long)atomic64_dec_and_test(v); + return atomic64_dec_and_test(v); } static inline int atomic_long_inc_and_test(atomic_long_t *l) { atomic64_t *v = (atomic64_t *)l; - return (long)atomic64_inc_and_test(v); + return atomic64_inc_and_test(v); } static inline int atomic_long_add_negative(long i, atomic_long_t *l) { atomic64_t *v = (atomic64_t *)l; - return (long)atomic64_add_negative(i, v); + return atomic64_add_negative(i, v); } static inline long atomic_long_add_return(long i, atomic_long_t *l) -- OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68